Skip to content

fix: use npm 11 OIDC login for trusted publishing - #1355

Merged
feanil merged 1 commit into
masterfrom
feanil/fix-npm-trusted-publishing
Oct 23, 2026
Merged

feanil merged 1 commit into
masterfrom
feanil/fix-npm-trusted-publishing

Conversation

@feanil

@feanil feanil commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Switch from Node 18 (npm 10) to Node 24 (npm 11) — npm 10 never requests a GitHub OIDC token for registry auth, only for provenance signing, so trusted publishing was silently falling back to the broken SEMANTIC_RELEASE_NPM_TOKEN
  • Remove the NODE_AUTH_TOKEN env var so npm uses OIDC login instead
  • Drop the npm ci step (no build/prepublish scripts; dev deps aren't needed for publishing)
  • Fix repository.url to https:// to avoid npm rewriting it to git:// at publish time

npm 10 (Node 18) never requests a GitHub OIDC token for registry auth —
it only uses it for provenance signing. Trusted publishing requires
npm >= 11.5.1, which ships with Node 24.

- Bump version to 6.1.4
- Switch node-version from 18 to 24
- Remove NODE_AUTH_TOKEN / SEMANTIC_RELEASE_NPM_TOKEN so npm uses
  OIDC login instead of the broken token
- Drop the npm ci step — there's no build or prepublish script, and
  the old dev dependencies don't install on Node 24
- Fix repository.url to https:// so npm doesn't rewrite it to git://
  at publish time (avoids provenance URL mismatch)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@feanil
feanil force-pushed the feanil/fix-npm-trusted-publishing branch from 86107e6 to ef7d824 Compare October 22, 2026 19:16
@feanil
feanil marked this pull request as ready for review October 22, 2026 19:16
@feanil
feanil merged commit e708809 into master Oct 23, 2026
15 checks passed
@feanil
feanil deleted the feanil/fix-npm-trusted-publishing branch October 23, 2026 13:17
farhan added a commit to farhan/edx-proctoring that referenced this pull request Oct 27, 2026
Nothing in the publish step needs node_modules: there is no build or
prepublish script and the published files are static assets. Skipping
the install keeps third-party install scripts out of a job that holds
an OIDC publish token, matching master's publish workflow (openedx#1355).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant