Repository navigation
fix: use npm 11 OIDC login for trusted publishing - #1355
Merged
Merged
Conversation
npm 10 (Node 18) never requests a GitHub OIDC token for registry auth — it only uses it for provenance signing. Trusted publishing requires npm >= 11.5.1, which ships with Node 24. - Bump version to 6.1.4 - Switch node-version from 18 to 24 - Remove NODE_AUTH_TOKEN / SEMANTIC_RELEASE_NPM_TOKEN so npm uses OIDC login instead of the broken token - Drop the npm ci step — there's no build or prepublish script, and the old dev dependencies don't install on Node 24 - Fix repository.url to https:// so npm doesn't rewrite it to git:// at publish time (avoids provenance URL mismatch) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feanil
force-pushed
the
feanil/fix-npm-trusted-publishing
branch
from
October 22, 2026 19:16
86107e6 to
ef7d824
Compare
feanil
marked this pull request as ready for review
October 22, 2026 19:16
farhan
added a commit
to farhan/edx-proctoring
that referenced
this pull request
Oct 27, 2026
Nothing in the publish step needs node_modules: there is no build or prepublish script and the published files are static assets. Skipping the install keeps third-party install scripts out of a job that holds an OIDC publish token, matching master's publish workflow (openedx#1355). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEMANTIC_RELEASE_NPM_TOKENNODE_AUTH_TOKENenv var so npm uses OIDC login insteadnpm cistep (no build/prepublish scripts; dev deps aren't needed for publishing)repository.urltohttps://to avoid npm rewriting it togit://at publish time