Repository navigation
feat: show the course escalation email on onboarding pages - #1360
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The proctored exam error page and the review result emails already ask learners to contact the course's proctoring escalation email. The onboarding pages still showed the provider's integration_specific_email, which falls back to the site-wide CONTACT_EMAIL, so learners in a course with its own proctoring contact were sent to general support instead. Both places that build integration_specific_email, the proctoring settings API used by the learning MFE and the student view context used by the LMS templates, now use the course's escalation email when it is set. Each already looks that email up for proctoring_escalation_email, so the value is fetched once and reused.
21965f5 to
778f0cc
Compare
Description
Related: https://github.com/mitodl/hq/issues/13163
When a course sets a proctoring escalation email, the proctored exam error page and the review result emails ask learners to contact that address. The onboarding pages don't: they show the provider's
integration_specific_email, or the site-wideCONTACT_EMAILwhen the provider has none. So a learner whose onboarding is missing, pending or rejected is sent to general site support instead of the course team that chose to handle proctoring questions.This PR makes both places that build
integration_specific_emailuse the course's escalation email when one is set, falling back toget_integration_specific_email(provider)as before:/api/edx_proctoring/v1/proctored_exam/settings/exam_id/<id>/), used byfrontend-lib-special-examsin the learning MFEEach already looks up the escalation email for
proctoring_escalation_email, so it is fetched once and reused.Courses without an escalation email see no change. For a provider that requires one, such as Proctortrack, every course has one, so its onboarding pages will now show the course team's address instead of the provider or site address.
Testing
Automated:
pytest src/edx_proctoring/tests/test_mfe_views.py src/edx_proctoring/tests/test_student_view.py -k "escalation_email or integration_specific_email"Manual:
requires_escalation_email: TrueinPROCTORING_BACKENDS(for example Proctortrack).course-team@example.comand click Save.→ "You must complete an onboarding exam before taking this proctored exam" now ends with "contact course-team@example.com". Before this change it showed the site's
CONTACT_EMAIL(or the provider'sintegration_specific_email).→ "Please contact course-team@example.com if you have questions."
GET /api/edx_proctoring/v1/proctored_exam/settings/exam_id/<exam id>/→
integration_specific_emailiscourse-team@example.com.Pre-Merge Checklist: