Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
_retire_proctored_exam_software_secure_review_and_history_and_commentclearedraw_data/encrypted_video_urlby calling.save()on each review and review-history row. Saving aProctoredExamSoftwareSecureReviewfires:pre_save→on_review_changed: archives the un-retired review, PII included, intoProctoredExamSoftwareSecureReviewHistory.post_save→finish_review_workflow: callsget_backend_provider()for the exam (this raises when the backend was removed fromPROCTORING_BACKENDS), thenupdate_attempt_status()(credit/grades/certificates side effects) and emitsreview_received.Retirement only needs to scrub PII. Re-running the review workflow is unnecessary and can fail.
Fix
Clear the fields with
QuerySet.update()on the reviews and review history, so no save signals fire. Comment retirement is unchanged (it already usedbulk_update).Behavior changes:
review_receivedevents.