Skip to content

Update of-watchdog to 0.12.3 - #80

Merged
alexellis merged 1 commit into
masterfrom
of-watchdog-0.12.3
Sep 30, 2026
Merged

alexellis merged 1 commit into
masterfrom
of-watchdog-0.12.3

Conversation

@alexellis

Copy link
Copy Markdown
Member

Description

Bump of-watchdog to 0.12.3.

When OAuth login is enabled, the session cookie no longer holds the provider's access and ID tokens (openfaas/of-watchdog#170). Only federated identity claims are kept.

How has this been tested?

Built a function from one of this repo's templates with faas-cli build. The image contains of-watchdog 0.12.3 (SHA dbafc24).

of-watchdog 0.12.3 no longer stores the OAuth provider's access and
ID tokens in the session cookie. Only federated identity claims are
kept.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis
alexellis merged commit 804314f into master Sep 30, 2026
2 checks passed
@reviewfn

reviewfn Bot commented Sep 30, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates the of-watchdog base image from 0.11.6 to 0.12.3 across five Python templates.
  • Affects Python 2.7 Flask, Python 3 Flask, Python 3 Flask Debian, Python 3 HTTP, and Python 3 HTTP Debian Dockerfiles.
  • Leaves the copied binary path, execution command, healthcheck, and watchdog environment variables unchanged.
  • No scoped code or template changes beyond the image tag bump were found.
  • No blocking correctness, migration, or consistency issues were identified in the scoped diff.

Approval rating (1-10)

9/10. The change is narrow and consistent; remaining risk is limited to the external image behavior of the new watchdog release.

Summary per file

Summary per file
File path Summary
template/python27-flask/Dockerfile Bumps of-watchdog image tag to 0.12.3.
template/python3-flask-debian/Dockerfile Bumps of-watchdog image tag to 0.12.3.
template/python3-flask/Dockerfile Bumps of-watchdog image tag to 0.12.3.
template/python3-http-debian/Dockerfile Bumps of-watchdog image tag to 0.12.3.
template/python3-http/Dockerfile Bumps of-watchdog image tag to 0.12.3.

Overall Assessment

This is a low-risk template update. The changed Dockerfiles consistently reference ghcr.io/openfaas/of-watchdog:0.12.3, and the templates continue to copy /fwatchdog into /usr/bin/fwatchdog and execute CMD ["fwatchdog"] as before. Within the scoped diff, I did not find a concrete issue that should block merging.

Detailed Review

Detailed Review

No blocking findings.

The scoped diff only updates the watchdog image tag in the five affected Dockerfiles. The surrounding template wiring remains consistent: each updated template still copies /fwatchdog, preserves executable permissions, keeps HTTP mode configuration, and starts fwatchdog as the container command.

AI agent details.

Agent processing time: 51.684s
Environment preparation time: 3.832s
Total time from webhook: 57.997s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant