Repository navigation
Conversation
Wraps every command the image runs to log the same start and finish metrics lines as the openmethane image, so wrf-run and wrf-download_geog can be sized from measured CPU and memory rather than guessed. The wrapper keeps waiting for the command after forwarding a signal, so run-wrf.sh can still copy partial output off the scratch disk when a job is stopped. Closes #86 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
Author
|
Closing, as the perf testing this was made for is concluded. Results are in #89 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86.
wrf-runasks for 63 vCPU and 32000 MiB, and neither has been measured. This adds the same[om-metrics]start/finish lines the openmethane image emits (openmethane/openmethane#235), so one aust10km daily run is enough to size it:Changes
scripts/docker-entrypoint-debug.sh: a port of the openmethane wrapper, with the same fields and format. Unlike openmethane, it runs the command directly and passes on its real exit code, because setup-wrf has no entrypoint of its own.Dockerfile: installstiniand sets the wrapper as theENTRYPOINT. Batch'scommandreplaces onlyCMD, sowrf-runandwrf-download_geogare measured with no om-infra change.docker run -itsessions run the command directly and are not measured. A backgrounded command would otherwise get/dev/nullas stdin.run-wrf.shwas still copying partial output from/mnt/scratchto EFS.docs/development.md: a short section on the metrics.Scratch cleanup is deliberately left out of the entrypoint.
run-wrf.shalready syncs and then removes itsRUN_DIRon exit. A blanketrm -rf $CHK_PATH/*would risk wiping other jobs' data, sincerun-wrf.shdefaultsCHK_PATHto the shared/mnt/scratch.Reading the results for wrf-run
real.exeandwrf.exe.mean_parallelismwill therefore sit below the rank count. Thetimeoutput aroundmpiruninrun.shcoverswrf.exeon its own.safe_mpi_tasks()sizes ranks fromos.cpu_count(). Batch uses CPU shares rather than a quota, so this is probably the host's 64 vCPUs, not the 63 requested. Therunning with N mpi rankslog line will confirm it.Testing
make test: 38 passed.--cpus/--memorylimits. The start and finish lines parse, and the exit code passes through.docker stopon a container whose command has an exit trap: the trap now completes before the container exits. Before the fix it was cut off.🤖 Generated with Claude Code