Repository navigation
Conversation
tt-a1i
left a comment
There was a problem hiding this comment.
Reviewed head: 1f4e06cd14e3102310ced2b7a0154f7c5baab9fe against main a18f457687b45c877bc8a15d689a7580c4f0659a.
Standards: no confirmed code-level blocker in the scoped change.
Spec: the inspected change matches the stated behavior in this PR. The compatibility CI implementation is separate from formally adopting its proposed support-policy Decision.
Validation: node --test --experimental-strip-types tests/extensions/setup/package-contract.test.ts: 通过 8 项;Node26.8.1,archive exact head,共享Pi0.99.1依赖
The unchanged-head focused receipts are reused after a live head/main refresh; #718 uses this round's latest-head tests. This code review does not claim installed-runtime, live-provider, full merged-queue or visual acceptance. No merge is authorized by this review.
|
Thanks for this. #815 has now landed on |
920c578 to
0eac7ae
Compare
Problem
Refs #328. The frozen Node matrix exercises Pi 1.2.0 while the published peer floor is 0.99.1. It cannot independently detect minimum-host or newly released stable-host incompatibility.
The new endpoints exposed existing drift: Web configuration imports a module absent from Pi 0.99.1; Pi 1.5.0 changes
StringEnum's schema type; and Pi 1.3+ drops cross-model thinking where older hosts converted it to text. OpenPI's search replay still counted the old text row, so later saved answers could be rejected. New renderer, dialog and persistence contracts also need accurate tests. The selector incorrectly rejects Pi 1.5.0's declaredpi-schemapackage.Value
Continuously verify the declared support endpoints, restore their existing behavior, and retain reproducible frozen-host checks. Pi and credentials remain host-owned; published support ranges are unchanged.
Approach
finally. Verify listing tokens, physical identities, exact versions and the real coding-agent entry. Acceptpi-schemaonly when the verified host declares the exact selected version; missing, mixed, unknown or undeclared packages still fail closed.Type.Enum, preserving string type, values, descriptions and defaults. Extract the existing reasoning-level list into a browser-safe shared leaf, retaining setup-config exports, instead of importing the SDK module missing from the minimum host. Regenerate the committed Web build.VERSIONand the documented Pi 1.3.0 conversion boundary to select one exact thinking projection. Keep row/block counts, ordinary content, arguments, tool IDs and repeated-answer ownership checks.VERSIONstays in the server extension entry and is passed explicitly into the pure replay function, keeping the browser's evidence reader free of SDK runtime imports.0addb739. Preserve main's Decision 0005 and renumber the still-proposed support policy to Decision 0006. This does not adopt that policy or close chore(deps): define and enforce the supported Pi baseline #328.Validation
Current head:
4e12b7b18f277c6e7415153fe20999c3b7a9d325.Current-head CI run 41630860431 completed successfully on 2026-11-03: all 19 jobs passed, including all Linux/Windows runtime and UI jobs, both Web E2E shards, provider handoff and aggregate gates. The minimum job verified Pi 0.99.1 (seven packages) with 2,455 Node tests passed / 15 skipped / 0 failed; the latest job verified Pi 1.5.0 (eight packages) with 2,462 passed / 8 skipped / 0 failed. Each endpoint also passed the full check, committed-Web-build verification and all four installation smokes.
bun run checkpackage.jsonandbun.lockbytes were restored. The final checkout uses frozen Pi 1.2.0; no TypeBox pin or published-range change is included.b9dc6762had 2,460 passed / 8 skipped / 2 unchanged Code Mode failures attests/extensions/code-mode/index.test.ts:181and:203. A fresh clean-main@0addb739control with the same frozen dependencies reproduces both. No local green locked complete-suite result is claimed.app.jsandbuild-info.jsonhashes. Browser builds contain no newly externalized Node SDK modules.git diff --check: passed.Impact