Repository navigation
Fix inconsistency for disabling frequency matching for generator channel - #436
Merged
Merged
Conversation
Contributor
|
Good catch. I think the original intent was that if you didn't want matching you would omit Thanks, and good to see you again since #293. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docstrings for the
add_readoutconfig()function inasm_v2.py, it is mentioned that in order to disable frequency matching, one must setgen_ch=None. However in practice, passinggen_ch=Noneexplicitly raises a KeyError.With the current implementation, this is checked by passing the parameter onto a dictionary
parwhich then is used to check the existence of the keygen_chinstead of its valueNone.With this fix, the docstring and code agree with each other i.e. setting
gen_chasNonenow disables frequency matching.It also replaces the KeyError with a RuntimeError that names the readout and generator channels.