[mcp_gateway] config: enable S3 import/export and regression analysis - #143
Conversation
… regression analysis Add S3 backend configuration for storing and retrieving historical KPI data, enabling regression analysis against past nightly runs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 18 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe orchestration configuration adds an optional AWS S3 vault. It expands Caliper postprocessing with KPI CSV output, optional AI-data output, historical regression analysis, and nightly S3 import/export settings. ChangesCaliper postprocessing configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/mcp_gateway/orchestration/config.yaml`:
- Around line 38-43: Remove the unsupported generate and export keys from the
KPI configuration, leaving artifacts_to_kpis.enabled and its supported output
field as the sole JSON output configuration. Ensure the output path is specified
through artifacts_to_kpis.output so caliper.postprocess.kpi validation succeeds.
- Around line 56-76: Move the entire s3 configuration block, including its
vault, import, and export settings, under the existing postprocess configuration
so it binds as caliper.postprocess.s3. Preserve all current S3 values and
nesting beneath the relocated block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8a294f2d-2e9d-4e95-add8-c31084c27105
📒 Files selected for processing (1)
projects/mcp_gateway/orchestration/config.yaml
| s3: | ||
| bucket: psap-dashboard-data | ||
| instance: mcp_gateway | ||
| directory: nightly | ||
| vault: | ||
| name: psap-forge-aws-s3-export | ||
| aws_credentials_file: aws.credentials | ||
| import: | ||
| enabled: true | ||
| output_dir: historical_data | ||
| include_kpis_json: true | ||
| include_kpis_csv: true | ||
| include_ai_data: false | ||
| max_downloads: 50 | ||
| export: | ||
| enabled: true | ||
| upload_id: null | ||
| dry_run: false | ||
| include_csv: true | ||
| include_kpis_json: true | ||
| include_ai_data: false |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Nest the S3 block under postprocess.
This s3: key is aligned with postprocess, making it caliper.s3; the contract expects caliper.postprocess.s3. As written, the configured import/export settings will not bind to the postprocessing S3 configuration, so historical KPI retrieval and uploads will not run as intended.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@projects/mcp_gateway/orchestration/config.yaml` around lines 56 - 76, Move
the entire s3 configuration block, including its vault, import, and export
settings, under the existing postprocess configuration so it binds as
caliper.postprocess.s3. Preserve all current S3 values and nesting beneath the
relocated block.
|
/test fournos mcp_gateway demo |
🔴 Execution of
|
🔴 Submission of
|
These fields are not recognized by CaliperOrchestrationKpiSection (extra="forbid") and cause pydantic validation to fail during postprocessing. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/test fournos mcp_gateway demo |
🔴 Execution of
|
🔴 Submission of
|
|
@ashtarkb: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I'll merge #136 soon, that will fix one thing you may want to do is to add a flag |
|
@kpouget I think that this PR is good to be merged, the fail_on_regression: false may be added in another PR |
|
thanks Avi, let's merge this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
Enable S3 historical KPI storage and regression analysis for mcp_gateway nightly runs.
Made with Cursor
Summary by CodeRabbit