Skip to content

STOR-3014: Promote SELinuxMountGAReadiness to GA - #2964

Draft
jsafrane wants to merge 1 commit into
openshift:masterfrom
jsafrane:promote-selinuxmountgareadiness
Draft

STOR-3014: Promote SELinuxMountGAReadiness to GA#2964
jsafrane wants to merge 1 commit into
openshift:masterfrom
jsafrane:promote-selinuxmountgareadiness

Conversation

@jsafrane

@jsafrane jsafrane commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Promote the gate to GA.

Starting as a draft, the CI tests got merged a day or two ago. Checking if everything works and the tests are found.

Enhancement: https://github.com/openshift/enhancements/blob/master/enhancements/storage/selinuxmount-ga-block-upgrade.md

  • There are only 4 tests. This was acknowledged during the enhancement review (there are not so many different cases to test).
  • The test are running in -serial jobs and therefore some clouds / OCP flavours may be missing.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown

@jsafrane: This pull request references STOR-3014 which is a valid jira issue.

Details

In response to this:

Promote the gate to GA.

Starting as a draft, the CI tests got merged a day or two ago. Checking if everything works and the tests work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

SELinuxMountGAReadiness now enables for the Default and OKD feature sets. The corresponding HyperShift and SelfManagedHA feature-gate manifests move it from their disabled lists to enabled lists. The feature-gate documentation table also relocates the row without changing its enabled-state markers.

Suggested reviewers: vr4manta, sadasu, mdbooth

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Patch only updates feature-gate metadata/manifests; no Ginkgo It/Describe/Context/When titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes feature-gate docs/registrations/manifests; no Ginkgo tests were added or edited, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes feature-gate registration and manifests, so MicroShift test compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; only feature-gate metadata/manifests changed, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only feature-gate docs/manifests changed; no deployment/operator/controller scheduling logic or topology constraints were added.
Ote Binary Stdout Contract ✅ Passed No process-level stdout writes were added; the PR only changes feature-gate metadata/manifests, and features/*.go has no Print/Stdout logging.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes feature-gate docs/manifests and registration; no new Ginkgo e2e tests or network-dependent code were added.
No-Weak-Crypto ✅ Passed PR only promotes SELinuxMountGAReadiness in feature-gate files; no whole-token MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code appears in changed files.
Container-Privileges ✅ Passed PR only edits feature-gate docs/manifests; no privileged/root/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Changed files only adjust feature-gate enablement/order; no log statements or sensitive literals (passwords, tokens, PII, hostnames) were added.
Title check ✅ Passed The title clearly matches the main change: promoting SELinuxMountGAReadiness to GA.
Description check ✅ Passed The description is related to promoting the gate to GA and mentions the CI/test validation context.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2026
@jsafrane

Copy link
Copy Markdown
Contributor Author

/test verify-feature-promotion

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qodo-for-rh-openshift

qodo-for-rh-openshift Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

@jsafrane
jsafrane force-pushed the promote-selinuxmountgareadiness branch from 6da247f to 6d3854a Compare July 30, 2026 15:42
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2026
@jsafrane

Copy link
Copy Markdown
Contributor Author

/test verify-feature-promotion

@qodo-for-rh-openshift

qodo-for-rh-openshift Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

@jsafrane

Copy link
Copy Markdown
Contributor Author

/test verify-feature-promotion

there should be metal-serial job

@qodo-for-rh-openshift

qodo-for-rh-openshift Bot commented Jul 31, 2026

Copy link
Copy Markdown

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 6d3854a link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants