Skip to content

Promote VolumeGroupSnapshots to GA - #2965

Draft
jsafrane wants to merge 1 commit into
openshift:masterfrom
jsafrane:promote-vgs
Draft

Promote VolumeGroupSnapshots to GA#2965
jsafrane wants to merge 1 commit into
openshift:masterfrom
jsafrane:promote-vgs

Conversation

@jsafrane

@jsafrane jsafrane commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Promote the gate to GA.

Starting as a draft to avoid surprises. Code was merged a long time ago, the last cleanup was merged today.

  • E2e tests that run in all regular e2e parallel should have enough coverage.
  • Some e2e tests are serial and thus may miss coverage, sometimes by one.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

VolumeGroupSnapshot is now enabled for Default and OKD configurations in the feature-gate definition. Its feature matrix position was updated, and four Hypershift and SelfManagedHA payload manifests now list it under enabled rather than disabled feature gates.

Suggested reviewers: vr4manta, sadasu, mdbooth

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were changed; the PR only touches docs, feature-gate code, and YAML manifests.
Test Structure And Quality ✅ Passed No Ginkgo/test code changed in this PR; only feature-gate docs/manifests were updated.
Microshift Test Compatibility ✅ Passed Only docs/config feature-gate files changed; no Ginkgo e2e test files or MicroShift-sensitive test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates feature-gate docs/manifests; no new Ginkgo e2e tests or SNO-unsafe assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Changes only adjust feature-gate metadata and enable VolumeGroupSnapshot; no pod specs, replicas, affinity, node selectors, or topology constraints were modified.
Ote Binary Stdout Contract ✅ Passed PR only changes feature-gate metadata/enablement; no main/init/TestMain/suite setup stdout writes were added in touched files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only edits feature-gate docs/config manifests; no new Ginkgo e2e tests or IP/network logic were added, so this check is not applicable.
No-Weak-Crypto ✅ Passed Touched files only move VolumeGroupSnapshot feature-gate entries; no weak-crypto APIs/patterns or secret comparisons were introduced.
Container-Privileges ✅ Passed Changed files are feature-gate docs/manifests only; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings found.
No-Sensitive-Data-In-Logs ✅ Passed No logging changes; the diff only updates feature-gate enablement/docs/manifests and adds no log statements or sensitive values.
Title check ✅ Passed The title clearly summarizes the main change: promoting VolumeGroupSnapshot(s) to GA.
Description check ✅ Passed The description is directly about promoting the gate to GA and matches the feature-gate manifest changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane

Copy link
Copy Markdown
Contributor Author

/test verify-feature-promotion

@qodo-for-rh-openshift

qodo-for-rh-openshift Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 0953058 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant