Skip to content

CM-1216: Apply sustaining CVE backport for golang.org/x/net - #471

Open
sujkini wants to merge 1 commit into
openshift:cert-manager-1.18from
sujkini:sujkini/cm-1216-operator
Open

sujkini wants to merge 1 commit into
openshift:cert-manager-1.18from
sujkini:sujkini/cm-1216-operator

Conversation

@sujkini

@sujkini sujkini commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • Applies sustaining CVE backport: replace golang.org/x/net => openshift-sustaining/net@v0.50.0-sec.2
  • Fixes reachable CVE-2026-39821 (Critical, CVSS 9.6) in the HTTP/2 transport layer used for Kubernetes API communication
  • go mod tidy pulled in transitive golang.org/x/ dependency updates to satisfy minimum version requirements of the new x/net

CVEs Fixed

CVE Severity Package Reachable
CVE-2026-39821 Critical (9.6) golang.org/x/net/idna Yes — via HTTP/2 transport
CVE-2026-25681 Medium golang.org/x/net/html No — same module, fixed by same replace
CVE-2026-27136 Medium golang.org/x/net/html No — same module, fixed by same replace

Verification

  • go build ./...
  • govulncheck ./... confirms x/net vulnerabilities resolved ✅

Jira: CM-1216

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 10, 2026

Copy link
Copy Markdown

@sujkini: This pull request references CM-1216 which is a valid jira issue.

Details

In response to this:

Summary

  • Applies sustaining CVE backport: replace golang.org/x/net => openshift-sustaining/net@v0.50.0-sec.2
  • Fixes reachable CVE-2026-39821 (Critical, CVSS 9.6) in the HTTP/2 transport layer used for Kubernetes API communication
  • go mod tidy pulled in transitive golang.org/x/ dependency updates to satisfy minimum version requirements of the new x/net

CVEs Fixed

CVE Severity Package Reachable
CVE-2026-39821 Critical (9.6) golang.org/x/net/idna Yes — via HTTP/2 transport
CVE-2026-25681 Medium golang.org/x/net/html No — same module, fixed by same replace
CVE-2026-27136 Medium golang.org/x/net/html No — same module, fixed by same replace

Verification

  • go build ./...
  • govulncheck ./... confirms x/net vulnerabilities resolved ✅

Jira: CM-1216

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 109bdb8d-947c-43c2-9b36-ec11d6629a93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sujkini
sujkini marked this pull request as ready for review August 24, 2026 07:11
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2026
Adds replace directive for golang.org/x/net to fix reachable CVE-2026-39821
(Critical, CVSS 9.6) in the HTTP/2 transport layer used for Kubernetes API
communication. The openshift-sustaining/net fork backports the fix to the
Go 1.24 dependency tree without requiring a full module upgrade.
- CVE-2026-39821: golang.org/x/net/idna Punycode bypass (reachable)
- CVE-2026-25681: golang.org/x/net/html parsing bypass (same module, not reachable)
- CVE-2026-27136: golang.org/x/net/html parsing bypass (same module, not reachable)
replace golang.org/x/net => openshift-sustaining/net@v0.50.0-sec.2
Jira: CM-1216
Signed-off-by: Sujnyan Kini <skini@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sujkini
sujkini force-pushed the sujkini/cm-1216-operator branch from 6cd6d52 to b8da531 Compare August 24, 2026 07:13
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@sujkini: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bharath-b-rh bharath-b-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2026
@bharath-b-rh

Copy link
Copy Markdown
Contributor

adding other required labels based on the CI checks
/label docs-approved
/label qe-approved
/label px-approved

@openshift-ci openshift-ci Bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 15, 2026
@bharath-b-rh

Copy link
Copy Markdown
Contributor

/cancel lgtm

@bharath-b-rh

Copy link
Copy Markdown
Contributor

/lgtm cancel

@bharath-b-rh

bharath-b-rh commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/hold

for @mytreya-rh / @arun717 reviews.

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2026
@arun717

arun717 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

The go.mod changes looks good.
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arun717, sujkini
Once this PR has been reviewed and has the lgtm label, please ask for approval from bharath-b-rh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants