Skip to content

OCPBUGS-98988: [4.19] Stabilize telemetry config to prevent continuous console pod rollouts#1193

Open
sg00dwin wants to merge 2 commits into
openshift:release-4.19from
sg00dwin:OCPBUGS-90370-backport-4.19
Open

OCPBUGS-98988: [4.19] Stabilize telemetry config to prevent continuous console pod rollouts#1193
sg00dwin wants to merge 2 commits into
openshift:release-4.19from
sg00dwin:OCPBUGS-90370-backport-4.19

Conversation

@sg00dwin

Copy link
Copy Markdown
Member

Summary

Backport of #1173 to release-4.19.

  • OCPBUGS-90370: Stabilize telemetry config to prevent continuous console pod rollouts
  • OCPBUGS-87348: Make GetAccessToken graceful when cloud.openshift.com is absent

The telemetry configuration was producing different ConfigMap key sets depending on telemeter-client availability, causing the operator to continuously reconcile the ConfigMap and trigger rolling console pod restarts.

Cherry-pick notes

  • TestDeploymentProgressingByGeneration test dropped (from OCPBUGS-64688, not backported to 4.19)
  • All telemetry tests included

Test plan

  • go build ./... passes
  • Test compilation succeeds for changed packages
  • CI e2e tests pass

/jira:cherrypick OCPBUGS-90370

🤖 Generated with Claude Code

sg00dwin and others added 2 commits July 16, 2026 16:37
…is absent

Return ("", nil) instead of a hard error when cloud.openshift.com is
missing from the pull-secret. This is expected on disconnected clusters
and should not degrade the console operator.

Also replaces fmt.Println with klog.Errorf for JSON parse errors.

Co-authored-by: Santiago Greco <fsgreco@redhat.com>
Assisted-by: Claude (Opus 4.6)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-98988, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • expected dependent Jira Issue OCPBUGS-98986 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of #1173 to release-4.19.

  • OCPBUGS-90370: Stabilize telemetry config to prevent continuous console pod rollouts
  • OCPBUGS-87348: Make GetAccessToken graceful when cloud.openshift.com is absent

The telemetry configuration was producing different ConfigMap key sets depending on telemeter-client availability, causing the operator to continuously reconcile the ConfigMap and trigger rolling console pod restarts.

Cherry-pick notes

  • TestDeploymentProgressingByGeneration test dropped (from OCPBUGS-64688, not backported to 4.19)
  • All telemetry tests included

Test plan

  • go build ./... passes
  • Test compilation succeeds for changed packages
  • CI e2e tests pass

/jira:cherrypick OCPBUGS-90370

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a55e4e30-e965-42af-926d-05bf5c1cafc4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhadvig and spadgett July 16, 2026 20:38
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@sg00dwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodics-images f309e43 link true /test periodics-images
ci/prow/e2e-aws-console f309e43 link true /test e2e-aws-console
ci/prow/e2e-aws-operator f309e43 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sg00dwin sg00dwin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants