Skip to content

OCPBUGS-99051: Clarify masthead Quick create labels#16744

Open
itsptk wants to merge 4 commits into
openshift:mainfrom
itsptk:CONSOLE-5394
Open

OCPBUGS-99051: Clarify masthead Quick create labels#16744
itsptk wants to merge 4 commits into
openshift:mainfrom
itsptk:CONSOLE-5394

Conversation

@itsptk

@itsptk itsptk commented Jul 9, 2026

Copy link
Copy Markdown

Description

Clarify masthead Quick create (+) copy so users understand it creates resources (not whatever they are currently viewing in console), per UXDR-4295.

Tooltip / aria-label: Quick create → Create resources

Menu labels:

  • Import YAML → Create from YAML
  • Import from Git → Create from Git
  • Container images → Create from container image

Item tooltips and the Import YAML page title are unchanged.

Originally tracked as CONSOLE-5394; moved to a bug per eng feedback.

Fixes: https://issues.redhat.com/browse/OCPBUGS-99051

Screenshots

Tooltip:
image

Options:
image

Mobile kebab:
image

Testing

  1. Hover the masthead + button → tooltip reads Create resources
  2. Open the dropdown → Create from YAML / Git / container image
  3. Check mobile kebab Create from YAML label
  4. Confirm Import YAML page title unchanged

/assign @rhamilto @spadgett

Summary by CodeRabbit

  • UI Improvements
    • Updated the Quick Create menu to use clearer “Create…” labels.
    • Renamed options to “Create from YAML,” “Create from Git,” and “Create from container image.”
    • Updated the mobile utility menu to use “Create from YAML.”
    • Added corresponding English localization text.

Update the Quick create (+) tooltip and aria-label to use the cluster
infrastructureName from the Infrastructure resource, with a fallback
while loading.

https: //redhat.atlassian.net/browse/CONSOLE-5394
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@itsptk: This pull request references CONSOLE-5394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Analysis / Root cause:
Users cannot tell which cluster context the masthead Quick create (+) action applies to. UX research recommendation: UXDR-4295. Jira: CONSOLE-5394.

Solution description:

  • Fetch Infrastructure/cluster and read status.infrastructureName
  • Update Quick create tooltip and aria-label to Quick create in {{clusterName}}
  • Fallback to Quick create in cluster while loading or if name unavailable
  • Add getInfrastructureName selector and unit tests

Screenshots / screen recording:

Test setup:

  • OpenShift cluster with infrastructureName set
  • cd frontend && yarn run dev
  • source ./contrib/oc-environment.sh && ./bin/bridge
  • Open http://localhost:9000 and hover the masthead + button

Test cases:

  • Tooltip shows cluster name after Infrastructure loads
  • aria-label matches tooltip text
  • Quick create dropdown options unchanged
  • Fallback text shown while Infrastructure is loading

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Draft — do not merge. Pending PM/product alignment on final copy (dynamic infrastructureName vs static "in cluster" as written in CONSOLE-5394 acceptance criteria).

Reviewers and assignees:
@openshift/team-ux-review

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Quick create and masthead YAML actions now use create-oriented labels, including updated accessibility text. English localization entries were updated to match the revised UI copy.

Changes

Create-oriented resource labels

Layer / File(s) Summary
Quick create labels and localization
frontend/public/components/QuickCreate.tsx, frontend/public/locales/en/public.json
Quick create tooltips, accessibility text, dropdown items, action buttons, and English translations now use create-oriented labels.
Masthead YAML action label
frontend/public/components/masthead/masthead-toolbar.tsx
The mobile masthead YAML action now displays “Create from YAML”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: fsgreco, stefanonardo, rhamilto

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description covers summary, screenshots, and testing, but omits required analysis, solution, browser conformance, and reviewer sections. Add the missing template sections: Analysis / Root cause, Solution description, Browser conformance, Additional info, and Reviewers and assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes frontend copy/locales; no test files or Ginkgo titles (It/Describe/Context/When) were added or modified.
Test Structure And Quality ✅ Passed PR only changes frontend UI strings/locales; no Ginkgo test files or cluster-test code were touched, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes frontend UI strings/localization; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes UI strings and localization, so SNO-specific test compatibility is not implicated.
Topology-Aware Scheduling Compatibility ✅ Passed Only frontend UI/localization strings changed; no manifests, controllers, or pod scheduling logic were added or modified.
Ote Binary Stdout Contract ✅ Passed Only frontend UI text/localization changed; no process-level code or stdout-writing paths were added in main/setup code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes frontend labels, so IPv6/disconnected compatibility concerns are not applicable.
No-Weak-Crypto ✅ Passed Touched files only rename UI strings; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison logic appears.
Container-Privileges ✅ Passed Patch only changes frontend UI text in TSX/JSON; no container/K8s manifests or privilege settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Patch only changes UI copy; diff shows no console/logger calls or sensitive-data logging introduced.
Title check ✅ Passed The title is concise and accurately summarizes the UI label clarification in this PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Revert the infrastructureName-based tooltip. Console team review
confirmed status.infrastructureName is an internal infra slug (install
name plus random suffix), not a user-facing display name. The console
already fetches Infrastructure/cluster on Overview but deliberately
shows API URL, Cluster ID, and platform instead.

There is no canonical on-cluster cluster display name today; see
CONSOLE-2217 and the cluster naming doc. ACM and OCM use separate
identifiers. Static copy matches the Jira acceptance criteria and
avoids showing opaque values like babbar-9d6hs in the masthead.

https: //redhat.atlassian.net/browse/CONSOLE-5394
Co-authored-by: Cursor <cursoragent@cursor.com>
@itsptk itsptk changed the title CONSOLE-5394: Update Quick create tooltip to show cluster name CONSOLE-5394: Update Quick create tooltip to clarify cluster context Jul 10, 2026
Rename dropdown items to Create from YAML, Create from Git, and Create
from container image so the menu clearly relates to Quick create.
Leave item tooltips and the Import YAML page title unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>
@itsptk itsptk changed the title CONSOLE-5394: Update Quick create tooltip to clarify cluster context CONSOLE-5394: Update Quick create tooltip to clarify cluster context and labels for clarity Jul 17, 2026
@itsptk
itsptk marked this pull request as ready for review July 17, 2026 17:47
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@itsptk

itsptk commented Jul 17, 2026

Copy link
Copy Markdown
Author

Ready for review.

/assign @rhamilto @spadgett
@openshift/team-ux-review

Scope: masthead Quick create tooltip + menu labels. Happy to iterate on copy if needed.

Clarify that the masthead action creates resources rather than implying
cluster context, per UX review with Ali and Sam.

Co-authored-by: Cursor <cursoragent@cursor.com>
@itsptk itsptk changed the title CONSOLE-5394: Update Quick create tooltip to clarify cluster context and labels for clarity OCPBUGS-99051: Clarify masthead Quick create labels Jul 17, 2026
@itsptk

itsptk commented Jul 17, 2026

Copy link
Copy Markdown
Author

Updated per Ali/Sam feedback: tooltip is now Create resources (not "Quick create in cluster"). Tracking moved to https://issues.redhat.com/browse/OCPBUGS-99051

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@itsptk: This pull request references Jira Issue OCPBUGS-99051, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Clarify masthead Quick create (+) copy so users understand it creates resources (not whatever they are currently viewing in console), per UXDR-4295.

Tooltip / aria-label: Quick create → Create resources

Menu labels:

  • Import YAML → Create from YAML
  • Import from Git → Create from Git
  • Container images → Create from container image

Item tooltips and the Import YAML page title are unchanged.

Originally tracked as CONSOLE-5394; moved to a bug per eng feedback.

Fixes: https://issues.redhat.com/browse/OCPBUGS-99051

Screenshots

(leave for author)

Testing

  1. Hover the masthead + button → tooltip reads Create resources
  2. Open the dropdown → Create from YAML / Git / container image
  3. Check mobile kebab Create from YAML label
  4. Confirm Import YAML page title unchanged

/assign @rhamilto @spadgett

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsptk, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@itsptk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-playwright 5b5f291 link false /test e2e-playwright

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants