CNV-67257: Set physicalNetworkName on OVN localnet NADs created from the console - #477
CNV-67257: Set physicalNetworkName on OVN localnet NADs created from the console#477smunaval wants to merge 1 commit into
Conversation
…the console The NAD form wrote the bridge mapping into CNI name and omitted physicalNetworkName, so multiple VLAN NADs on one mapping collided. Jira: https://issues.redhat.com/browse/CNV-67257 RFE: https://issues.redhat.com/browse/RFE-9664 Case: 04498484 Signed-off-by: suhaskumar munavalli <smunaval@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@smunaval: This pull request references CNV-67257 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smunaval The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @smunaval. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vojtechszocs @upalatucci Could you please review this PR and comment |
…the console
The NAD form wrote the bridge mapping into CNI name and omitted physicalNetworkName, so multiple VLAN NADs on one mapping collided.
Jira: https://issues.redhat.com/browse/CNV-67257
RFE: https://issues.redhat.com/browse/RFE-9664
Case: 04498484