Skip to content

Run e2e-v2-aws-techpreview-osimagestream test always on presubmit - #82874

Draft
csrwng wants to merge 1 commit into
openshift:mainfrom
csrwng:run-osstream-test-always
Draft

Run e2e-v2-aws-techpreview-osimagestream test always on presubmit#82874
csrwng wants to merge 1 commit into
openshift:mainfrom
csrwng:run-osstream-test-always

Conversation

@csrwng

@csrwng csrwng commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set always_run: true for the e2e-v2-aws-techpreview-osimagestream presubmit test in the HyperShift main config
  • Includes regenerated Prow job config

Test plan

  • Verify the presubmit job triggers automatically on PRs to openshift/hypershift

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configures e2e-v2-aws-techpreview-osimagestream to run automatically on all pull requests to openshift/hypershift.
  • Regenerates the related Prow job configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 50bdea9a-b47f-4b7a-a649-df02815a7563

📥 Commits

Reviewing files that changed from the base of the PR and between 40b7bf5 and bb5667c.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

Walkthrough

The change updates the Hypershift test configuration so e2e-v2-aws-techpreview-osimagestream runs on every change instead of requiring opt-in.

Changes

Hypershift test execution

Layer / File(s) Summary
Enable the osimagestream test on every change
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
Sets always_run to true for e2e-v2-aws-techpreview-osimagestream.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: jparrill, bryan-cox, devguyio

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: making the specified presubmit test run automatically.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only always_run in the HyperShift config and generated presubmit YAML; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The PR changes only two YAML configuration files; no Ginkgo test code or It blocks changed, so this test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration to enable an existing test; no new Ginkgo tests added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML CI configuration and generated Prow job data; it adds no Ginkgo e2e tests requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The change only sets always_run: true in a CI job configuration; it adds or modifies no deployment manifest, operator code, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML configuration files; it adds no OTE binary source or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two YAML files to set always_run: true; it adds no Ginkgo tests or networking code that requires IPv4 or external connectivity.
No-Weak-Crypto ✅ Passed The two-file patch changes only always_run: false to true for the named Prow test; it adds no weak crypto, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The diff only changes always_run from false to true; no changed manifest sets privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution.
No-Sensitive-Data-In-Logs ✅ Passed PR changes only set always_run: true in test configuration files with no new logging statements or sensitive data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@csrwng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-v2-aws-techpreview-osimagestream openshift/hypershift presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant