Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each command in a backlog gets copied into
char copy[128]before it runs. Anything past 127 characters is silently dropped. So a long command works when you send it on its own, and the same command inside a backlog quietly does something else. On its own it gets the tokenizer's 512.This splits one heap copy of the backlog in place instead, so every command keeps its full length. Splitting is unchanged: on
;, with empty commands handled the same way. Backlogs withdelay_ms,delay_sorwaitForgo through the script VM and aren't touched.Added a case to
Test_Backlog: one command over 127 characters, with the value sitting past the old cut. It fails on main and passes here. Unit tests pass, plain, ASan and UBSan.The 128-byte limit on a whole
/cmcommand got fixed at the HTTP layer a while back (elektroda topic3942155). This is the same limit one level down.