Repository navigation
Gate each occasion's sections in the Birnbaum and Haggadah running orders (opensiddur-ai#228) - #72
Merged
Merged
Conversation
…ders (opensiddur-ai#228) Regenerated with opensiddur-ai fix/occasion-gates: - Birnbaum (he, en) index.xml: each section said only on some days is conditioned at its transclusion, with what the condition fixes declared inside it. - Haggadah (Heidenheim, Feinstein): the seder is gated on the seder nights, the search and burning of leaven on the eve of Pesah; conditionals over passages the source brackets are type="marked". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shabbat Musaf and Kabbalat Shabbat gates; the biur and seder gates of the Haggadah. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rked" Birnbaum's starred seals, Magen Avot and (וְ)חָנֵּנוּ; the Feinstein kiddush's second "with love". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…parenthesised rubric scopes are marked Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with opensiddur/opensiddur-ai#229 (same branch name). Merge that PR first. For opensiddur/opensiddur-ai#228.
This regenerates the projects with the importers on
fix/occasion-gates.index.xml: each section said only on some days is conditioned where it is transcluded, and what the condition fixes is declared inside it. The life-cycle services are not gated.type="marked", so an undated edition still brackets them.Not regenerated, because the importer lags the repository there:
birnbaum_ashkenaz_en_1949/notes_minchah.xml(Anchor the Birnbaum Minhah commentary on the service title #60);index.xml.All changed files validate against the schema on the paired branch.
🤖 Generated with Claude Code