Skip to content

[operator_build] Make tasks fails on command error - #4171

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:op_build_err
Sep 11, 2026
Merged

[operator_build] Make tasks fails on command error#4171
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:op_build_err

Conversation

@karelyatin

@karelyatin karelyatin commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

These task succeeds always as the last command will never fail. Make the task fail on any command error by using set -eo pipefail.

@qodo-code-review

qodo-code-review Bot commented Sep 10, 2026

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

abays
abays previously approved these changes Sep 10, 2026
View reviewed changes

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Sep 10, 2026
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Sep 10, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/f26beacd7e9841dfadfaff7e210945e7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 11s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 29m 53s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 30s
❌ openstack-k8s-operators-content-provider-bootc FAILURE in 19m 16s
⚠️ cifmw-crc-podified-edpm-baremetal-bootc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider-bootc
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 30s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 11s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 16m 22s
❌ cifmw-molecule-operator_build FAILURE in 7m 42s

@openshift-ci openshift-ci Bot removed the lgtm label Sep 10, 2026
@karelyatin
[operator_build] Make tasks fails on command error
9e2fc1c 
These task succeeds always as the last command will never fail.
Make the task fail on any command error by using set -eo pipefail.

Also updated molecule scenario to setup download_tools as
that setups the pre requisites like golang.

Signed-off-by: Yatin Karel <ykarel@redhat.com>
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Sep 10, 2026

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/74ab8a4d3f7a42908514b7f2a5862310

✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 10m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 46s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 05m 05s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 15s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 3h 15m 36s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 28m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 34s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 15s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 13m 37s
✔️ cifmw-molecule-operator_build SUCCESS in 7m 47s

michburk
michburk approved these changes Sep 10, 2026
View reviewed changes

@michburk michburk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, michburk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

evallesp
evallesp approved these changes Sep 11, 2026
View reviewed changes

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 11, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 260fdc5 into openstack-k8s-operators:main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp approved these changes
@michburk michburk michburk approved these changes
@abays abays abays left review comments

Assignees

@abays abays

@evallesp evallesp

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karelyatin @abays @evallesp @michburk