Repository navigation
Conversation
Firefishy
force-pushed
the
add-podman-uid-allocation
branch
from
November 1, 2026 19:38
b395e77 to
1bc4f63
Compare
Member
Author
|
Removed the silly |
tomhughes
reviewed
Nov 2, 2026
tomhughes
left a comment
tomhughes
left a comment
Member
There was a problem hiding this comment.
I think my main question is whether this is the best solution or whether we'd be better allocating a host user for each container that needs to store files using our normal service user setup and then applying an idmap to the volume to map that user to the internal user in the container?
Comment on lines
+98
to
+104
| valid = source.is_a?(String) && source.start_with?("/") && | ||
| options[:target].is_a?(String) && options[:target].start_with?("/") && | ||
| (options.keys - [:target, :uid, :gid, :mode]).empty? && | ||
| [:uid, :gid].all? { |key| options.fetch(key, 0).is_a?(Integer) && options.fetch(key, 0).between?(0, 65535) } && | ||
| options.fetch(:mode, "0700").is_a?(String) && options.fetch(:mode, "0700").match?(/\A[0-7]{3,4}\z/) | ||
|
|
||
| raise "Invalid managed volume #{source.inspect} for #{new_resource.service}" unless valid |
Member
There was a problem hiding this comment.
I mean there's nothing wrong with this other than it being horrifically ugly but we wouldn't normally bother with such extreme validation.
Co-authored-by: Tom Hughes <tom@compton.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: AI was used for feedback and recommendation of the tests. Used: OpenAI GPT-6.1 Sol. All code has been reviewed by me.