Skip to content

test(openworkflow): synchronize parallel crash recovery - #788

Merged
jamescmartinez merged 1 commit into
mainfrom
fix-parallel-crash-recovery-test
Sep 19, 2026
Merged

jamescmartinez merged 1 commit into
mainfrom
fix-parallel-crash-recovery-test

Conversation

@jamescmartinez

Copy link
Copy Markdown
Contributor

Closes #710

@pkg-pr-new

pkg-pr-new Bot commented Sep 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/cli@788
npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/dashboard@788
npm i https://pkg.pr.new/openworkflowdev/openworkflow@788

commit: dce0b33

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the new synchronization matches the persistence semantics of step.run and introduces no actionable issue.

Summary

This PR makes the parallel crash-recovery test deterministic by delaying step-b’s simulated failure until step-a has completed and been persisted.

  • Preserves parallel step startup.
  • Ensures replay can recover step-a from its cached completion.
  • Changes test synchronization only; production behavior is unaffected.

Reviews (2) · Last reviewed commit: "test(openworkflow): synchronize parallel..."

Co-authored-by: yqin0512 <284203843+yqin0512@users.noreply.github.com>
@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jamescmartinez
jamescmartinez force-pushed the fix-parallel-crash-recovery-test branch from 1ba6a27 to dce0b33 Compare September 19, 2026 23:49
@jamescmartinez
jamescmartinez merged commit adf5814 into main Sep 19, 2026
10 checks passed
@jamescmartinez
jamescmartinez deleted the fix-parallel-crash-recovery-test branch September 19, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky parallel crash-recovery test needs explicit step synchronization

1 participant