ci: extend the concurrency guard to CodeQL - #1235
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Extends the existing CI concurrency guard to the CodeQL workflow so that superseded PR runs are cancelled and don’t keep consuming runners, while keeping non-PR triggers fully parallel.
Changes:
- Add the same
concurrencygroup/cancellation behavior to.github/workflows/codeql-analysis.yml. - Replace the long explanatory concurrency comment in
run-tests.yamlwith a shorter “what it’s for” comment, and add the same comment to CodeQL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/run-tests.yaml | Updates the concurrency comment to a shorter description of intent. |
| .github/workflows/codeql-analysis.yml | Adds concurrency grouping + PR cancellation to prevent redundant CodeQL runs from holding runners. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # on PRs only run the latest changes, everything else should run and also run | ||
| # in parallel. no queuing |
| # on PRs only run the latest changes, everything else should run and also run | ||
| # in parallel. no queuing |
CodeQL runs on every pull request and had no concurrency group, so a force-push during review left the superseded analysis holding runners alongside the test matrix. Give it the same group as the test workflow. Contract the comment in both files to a single line describing the intent rather than the mechanism.
3737d39 to
89a1612
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 62.34% 62.34%
=======================================
Files 40 40
Lines 3930 3930
=======================================
Hits 2450 2450
Misses 1480 1480 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
#1233 gave
run-tests.yamla concurrency group but left CodeQL uncovered, so aforce-push during review still leaves the superseded analysis holding runners.
Same triggers, same block, byte for byte.
Also contracts the comment in both files.