Conversation
* Add node label selector configuration for cloud controllers * Filter OCI node informers without filtering other resources * Document configuration and preserve all node behavior by default Signed-off-by: Dalton Hubble <dghubble@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
There was a problem hiding this comment.
Thanks for adding node-scoped reconciliation.
Testing requested
Could you please include the following in the PR description?
- Manual test results, including the commands executed.
- If possible, results from the CCM E2E suite using
FOCUS='[ccm]'.
This would provide additional confidence that the filtering change does not regress the external CCM controllers.
Filtering bypass found during review
We found a filtering bypass through the generic InformerFor path. Although Node requests were delegated to nodeFactory, the caller-provided constructor was passed through unchanged. Such a constructor can create an unfiltered Node informer because WithTweakListOptions is only captured by the generated typed constructor.
Since informers are cached by resource type, calling this path first can also cause typed callers to reuse the unfiltered cache.
Proposed fix
I opened dghubble/oci-cloud-controller-manager#1 with the fix and regression coverage. It ensures all Node InformerFor calls return the canonical filtered informer.
|
LGTM. will approve once the test results are shared and the aforementioned fix is in place |
Signed-off-by: Lalit Singh <lalit.s.singh@oracle.com>
|
I've incorporated the suggested change and regression coverage. Inquiring with my company and yours about how to satisfy the CLA. |
Summary
--node-filter-requirementsKubernetes label selector that restricts node-scoped reconciliation to matching NodesMotivation
The OCI Cloud Controller Manager currently attempts to reconcile every Node in a cluster. This causes provider-specific operations to fail in hybrid clusters containing Nodes managed by other cloud providers. Node filtering lets operators define which Nodes the OCI CCM should manage.
Review fix
InformerForcalls return the canonical filtered Node informerTesting
go test ./pkg/cloudprovider/providers/oci -run 'TestNewNodeFilteredSharedInformerFactory' -count=1go test ./pkg/cloudprovider/providers/oci -count=1The CCM E2E suite was not run because a configured Kubernetes and OCI test cluster was not available.