fix: register data models under their camelCase record type

[herzzanu]

Fixes #463.

Model files are kebab-case on disk, so setupOrbit receives glob keys like ../data-models/planetary-system.ts and registers the model under planetary-system. Both consumers of registrations.models look models up by camelCase record type instead, so every multi-word model is unreachable:

• DataSchema builds its model map from getRegisteredModels(), which camelized the keys and then indexed the un-camelized registry — the lookup returns undefined and destructuring throws during setupOrbit.
• Cache#modelFactoryFor(type) is called with the record type, so it hits the same mismatch and asserts "An ember-orbit model for type … has not been registered."

The change

Camelize once at registration, and let getRegisteredModels() return the keys as stored, so registration and lookup agree. Registry keys now match the record types used everywhere else, which is also what modelFactoryFor already assumed.

The alternative — keeping the registry kebab-cased and camelizing only the schema's model names — would leave modelFactoryFor needing its own conversion, so normalizing at the single write point seemed cleaner. Happy to switch if you'd prefer it the other way.

Why the existing suite didn't catch this

Both paths that register models avoid real kebab-case file names:

• Integration tests go through tests/support/store.ts#createStore, which synthesizes module keys from the dict keys the test passes — and those are already camelCase (binaryStar, planetarySystem).
• The test app's route globs a real folder, but tests/test-app/data-models/ only contains moon.ts and planet.ts, and camelize('moon') === 'moon'.

The added test closes that gap by registering a fixture under a kebab-case key, the way a real glob would.

Verification

Run against this repo's suite (Chrome; Firefox isn't installed locally):

• Without the source change, with the new test present: 172 passed, 2 failed, both with TypeError: Cannot destructure property 'keys' of 'orbitRegistry.registrations.models[name]' as it is undefined
• With the source change: 174/174 passed

prettier --check, eslint and tsc --noEmit are clean.

I also hit this on a classic ember-cli app (via ember-classic-import-meta-glob), where it prevented boot entirely; the failing test here runs through the Vite build, so it isn't builder-specific.

[herzzanu]

@RobbieTheWagner @NullVoxPopuli — small fix with a red/green test, would appreciate a look when you have a moment.
@lucacorti this may also cover the schema errors you hit in #431, if you're still on this path.

[lucacorti]

@herzzanu with this I get a build error:

ERROR in ../../../../../../private/var/folders/f7/4l5jd79d4zd4pf_rym3xbyzw0000gn/T/broccoli--69261-1r71sqhed9o9/cache-207-webpack_bundler_ember_auto_import_webpack/app.cjs 119:124-146
Module not found: Error: Package path . is exported from package /private/var/folders/f7/4l5jd79d4zd4pf_rym3xbyzw0000gn/T/broccoli--69261-1r71sqhed9o9/cache-207-webpack_bundler_ember_auto_import_webpack/node_modules/ember-orbit, but no valid target file was found (see exports field in /private/var/folders/f7/4l5jd79d4zd4pf_rym3xbyzw0000gn/T/broccoli--69261-1r71sqhed9o9/cache-207-webpack_bundler_ember_auto_import_webpack/node_modules/ember-orbit/package.json)

[herzzanu]

@lucacorti that one's not coming from this PR — it's how the branch is being installed.

dist/ is gitignored and only produced by rollup --config, which is wired to prepack. So the published tarball has dist/ + declarations/ and no src/, while a git checkout is the exact inverse. If you installed this from a git ref, node_modules/ember-orbit ends up with no dist/index.js, and since exports["."] points there, webpack reports it as "no valid target file was found".

It doesn't self-build on install because package.json has prepack but no prepare — package managers only install a git dependency's devDependencies and build it when a prepare script is present, so rollup is never there to run.

Easiest way to try the branch is to build a tarball:

git clone -b fix-kebab-case-model-names https://github.com/herzzanu/ember-orbit
cd ember-orbit && pnpm install && pnpm build   # emits dist/ + declarations/
npm pack                                       # -> ember-orbit-0.20.0.tgz
# then in your app:
pnpm add file:../ember-orbit/ember-orbit-0.20.0.tgz

Same applies if you linked a checkout — pnpm build has to run first.

Alternatively, patch the released 0.20.0 in place, since both edits land in the shipped bundle:

• dist/orbit-registry-*.js — in getRegisteredModels(), drop the .map(camelize)
• dist/index.js — in registerDataModels (the folder = '/data-models/' one, not the sources/strategies/buckets ones below it), change name = getName(name); to name = camelize(getName(name));, and add import { camelize } from '@orbit/serializers'; at the top of that file

Would be good to hear whether the fix actually resolves your #431 schema errors once it's building.