feat(main-menu): review approved Home and Play Hub hierarchy - #88
Draft
orbyteon wants to merge 7 commits into
Draft
feat(main-menu): review approved Home and Play Hub hierarchy#88orbyteon wants to merge 7 commits into
orbyteon wants to merge 7 commits into
Conversation
…main-menu-play-hub-20260904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency and review intent
Depends on #87: #87. This is a stacked draft PR, deliberately targeting the Solo feature branch, not
main. Review the Solo foundation first and this Main Menu-only delta second. Retargeting, integration and merge require separate authorization; auto-merge is not enabled.Verified remote provenance
feature/solo-vs-ai-production-20260901atcd2cd0799f45b4a5dca06ff83facd54b320eeb65.feature/main-menu-play-hub-20260904at10119028c7de41fbbb532e282c0c9997ae5297ef.f1f355bf62913f7d781c5af04d0e28d15e7c38ee— feat(mainmenu): add truthful play hub3d85191d3ef0cef65790f19a5eb6505b1b852a49— fix(main-menu): finalize play hub visual hierarchy10119028c7de41fbbb532e282c0c9997ae5297ef— test(main-menu): align background contracts with approved Solo artmainremains atebac6e6b3f55106183e9ed616d0ce485c716dd0e. The Solo changes are excluded from this PR comparison by the chosen base.Player-facing changes
PvpGameController.OpenPvpMenu()private-room flow, including the existing pink-door screen. Back closes the selector and returns to Home.Scope
Only Home/PLAY presentation, localization, real entry wiring, deterministic capture support and directly affected tests. The inherited Solo/first-launch test files change to exercise the PLAY-selector entry contract; this PR does not change Solo gameplay/pacing/AI, DuelRules, PvP backend/protocol, Daily Hunt gameplay, avatar persistence, scenes, ProjectSettings, packages or release configuration. No new PNG artwork, baked localized/dynamic text, artifacts, APKs or temporary paths are added.
Recorded human acceptance
Marinos approved the VS-AI-derived visual direction, card dimensions/presence, 32/32 text-centering result, final enlargement and logo +9% delivery. The final two-file stale-geometry test expectation corrections were explicitly authorized without production/capture changes, relaxed tolerances or removed assertions. Marinos then accepted the exact six-file finalization commit and remote backup at
3d85191d3ef0cef65790f19a5eb6505b1b852a49. The subsequent two-file Node contract correction was separately authorized and changes no presentation or production code.This is recorded product/visual acceptance from the working conversation, not a GitHub approving review and not proof that current CI has passed.
Previously recorded visual validation (before the test-only correction)
Source evidence:
MM_PLAY_HUB_TEST_GEOMETRY_20260905_01/focused-validation-audit.md, external local evidence, not committed or uploaded. Unity 2022.3.62f3, licensed interactive GUI. The recorded native Test Runner results are:MainMenuHomeVisualsPlayModeTests.HomeLocalizedGlyphsStayInsideApprovedArtSafeAreas: PASS.MainMenuHomeVisualsPlayModeTests.HomeMatchesApprovedPlayHubHierarchyAndRemainsPlayable: PASS.MainMenuHomeVisualsPlayModeTests.HomeProfileAvatarUsesCanonicalOnboardingSelectionWithoutMovingLayout: PASS.MainMenuPlayVisualsPlayModeTests.PlayHubLocalizedGlyphsRemainContainedAtAllRequiredViewports: 1 passed / 0 failed / 98 not run, 2.472 s.git diff --check: PASS in the finalization record.4BBDCD307D36E651B0358414C796303A85191B20FBF6F0C29E98D019551E1856.Preserved environmental failed attempt: the selector method first ran in landscape Free Aspect Game View and failed safe-root containment (2.313 s). Selecting the existing portrait preset produced the pass above with identical source and assertions. This is disclosed, not erased or portrayed as a production fix.
The four approved 1080x1920 Home/selector EN/EL captures and labeled contact sheet are preserved in external local folder
MM_VSAI_HOME_PLAY_EVIDENCE_20260905_14. Recorded centering evidence is 32/32. No evidence image was replaced during the final expectation correction.No XML export is claimed for the GUI-observed final focused run. No new complete suite, capture matrix, Android APK/AAB, or Node run was performed in that final test-expectation pass or in the original PR-preparation task. An earlier Main Menu APK does not validate this final visual revision as a fresh build.
Authorized two-file background-contract correction
Commit
10119028c7de41fbbb532e282c0c9997ae5297ef, parent3d85191d3ef0cef65790f19a5eb6505b1b852a49.Only
tools/test/mainmenu-assets.test.mjsandtools/test/panelplay-assets.test.mjschanged (27 insertions, 10 deletions). BothapprovedBackgroundpaths, resource-owner assertions and background-specific descriptions now require the existing approvedsolo/production/solo_background_v1, not either previous background.Read-only PNG inspection confirmed 941x1672, 8-bit RGB, matching the canonical Solo source dimensions. Both tests now assert those exact dimensions and PNG signature/bit depth, while retaining the original minimum width/height and approximately-9:16 tolerance. RGB/RGBA checks, Unity-meta presence, rejected-art deletion, Splash isolation, mascot identity, other asset checks and avatar persistence assertions remain intact. Old Settings/Revision-3 background references are explicitly rejected by the production-owner tests rather than accepted as alternatives.
PNG SHA-256 remains
A340C8F70F92B1815A3F0953CC8DE5BFADE6E0FC89F81B9368FB5EF79E71527D; meta SHA-256 remainsE74DB97559F12989C4E0654A405896D27D23E4053180DB9C0C20DA682303C12C. No artwork/import metadata was changed.Fresh local validation for this correction
Executed once per requested lane, with local Node v24.19.0 (the automatic GitHub workflow uses Node 22):
node --test tools/test/mainmenu-assets.test.mjs tools/test/panelplay-assets.test.mjs: 15 passed, 0 failed, 0 skipped, exit 0.node --check playfab/cloudscript.js: PASS, exit 0.node --test tools/test/*.test.mjs: 123 passed, 0 failed, 0 cancelled, 0 skipped, 0 todo, exit 0.git diff --check: PASS.git ls-remotematches10119028c7de41fbbb532e282c0c9997ae5297ef.No production, Unity test, workflow/configuration, capture, APK/AAB or source asset change. No Unity launch, CI dispatch/rerun, history rewrite, merge, or change to #87; both PRs remain draft.
Current CI and review blockers
The previous run 33947009507 reported 121/123 Node passes with the two stale background failures; its skipped EditMode/Android jobs remain historical skips, not passes.
The normal push automatically started the new CI run 33968469822 on
10119028c7de41fbbb532e282c0c9997ae5297ef. At the first post-push snapshot, Static integrity was in progress; Visual system integrity and Require Unity credentials had succeeded. The new overall CI and downstream substantive jobs are not yet verified green. Fresh local Node results above do not replace the current GitHub Node 22/merge-ref, EditMode, Android compile and applicable PlayMode gates. Pending/skipped checks are not passes.Review dependency #87 first. Both PRs remain drafts, with no auto-merge enabled. Recorded human acceptance does not replace formal review or the existing required CI gates. No final-revision APK/full capture matrix is claimed by this test-only correction.
Exact 17-path comparison manifest
Assets/SCRIPT/Design/MainMenuHomeVisuals.csAssets/SCRIPT/Design/MainMenuLocalCapturePlayer.csAssets/SCRIPT/Design/MainMenuPlayVisuals.csAssets/SCRIPT/Design/PanelPlayCaptureBootstrap.csAssets/SCRIPT/Localization/L10n.csAssets/SCRIPT/MenuManager.csAssets/SCRIPT/RuntimeUI/ExtrasRuntimeWiring.csAssets/Tests/EditMode/MainMenuProductionAssetsTests.csAssets/Tests/PlayMode/FirstLaunchSoloEndToEndPlayModeTests.csAssets/Tests/PlayMode/MainMenuHomeSubtitlePlayModeTests.csAssets/Tests/PlayMode/MainMenuHomeVisualsPlayModeTests.csAssets/Tests/PlayMode/MainMenuPlayVisualsPlayModeTests.csAssets/Tests/PlayMode/PanelPlayCapturePlayModeTests.csAssets/Tests/PlayMode/ResponsiveUIFoundationPlayModeTests.csAssets/Tests/PlayMode/SoloDuelVisualsPlayModeTests.cstools/test/mainmenu-assets.test.mjstools/test/panelplay-assets.test.mjs