Skip to content

fix: declare Google auth runtime dependency - #4090

Open
yedmalaaravind wants to merge 1 commit into
ory:mainfrom
yedmalaaravind:fix/4072-google-auth-dependency
Open

yedmalaaravind wants to merge 1 commit into
ory:mainfrom
yedmalaaravind:fix/4072-google-auth-dependency

Conversation

@yedmalaaravind

@yedmalaaravind yedmalaaravind commented Nov 12, 2026 •

Copy link
Copy Markdown

Declare google-auth-library 10.6.1 for Google Workspace directory sync and synchronize both lockfile dependency records. Reuse the version already resolved through googleapis-common.

Refs #4072

What does this PR do?

Fixes #4072.

Declares google-auth-library as a direct runtime dependency of @boxyhq/saml-jackson. Google Workspace directory sync imports this package directly, but it was available only through a transitive dependency, which can cause Cannot find module 'google-auth-library' errors with pnpm’s strict dependency isolation.

Uses version 10.6.1, already resolved through googleapis-common, and updates both lockfile dependency records.

Type of change

Updated dependencies

How should this be tested?

Verified that the library manifest and both lockfiles declare the same version.

Confirmed that the declared version matches the existing resolved runtime dependency

  • Existing unit tests
    N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Chores
    • This update includes an internal maintenance change. No user-facing features, behavior changes, or fixes are included.

Declare google-auth-library 10.6.1 for Google Workspace directory sync
and synchronize both lockfile dependency records. Reuse the version
already resolved through googleapis-common.

Refs ory#4072
@CLAassistant

CLAassistant commented Nov 12, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The package manifest adds google-auth-library version 10.6.1 to the dependencies.

Changes: Runtime dependency

Layer / File(s) Summary
Declare the runtime dependency
npm/package.json
The package dependencies now include google-auth-library version 10.6.1.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · up to 8be10

This change declares the Google auth library as a direct dependency, so Google Workspace directory sync no longer fails with a missing-module error under strict dependency isolation. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: declaring google-auth-library as a runtime dependency. It follows the fix: prefix and is short and specific. The raw summary shows only a one-line addition to npm/pack…
Description check Passed The description covers the main template sections. It explains the purpose (direct runtime dependency for Google Workspace directory sync), states the version (10.6.1), and links issue #4072 under 'Fi…
Linked Issues check Passed [#4072] Requirement: list google-auth-library in the dependencies of @boxyhq/saml-jackson's package.json. The PR adds google-auth-library 10.6.1 to npm/package.json as a runtime dependency (+1/-0 line…
Out of Scope Changes check Passed The reviewed change set is a single added dependency line in npm/package.json. It directly implements the objective of #4072. No unrelated source, test, or configuration changes appear in the summary.…
Full details: Title check

Explanation

The title names the main change: declaring google-auth-library as a runtime dependency. It follows the fix: prefix and is short and specific. The raw summary shows only a one-line addition to npm/package.json, which matches the title.

Full details: Description check

Explanation

The description covers the main template sections. It explains the purpose (direct runtime dependency for Google Workspace directory sync), states the version (10.6.1), and links issue #4072 under 'Fixes #4072'. It marks 'Updated dependencies' as the type of change and lists testing performed. Gaps: the 'Fixes # (issue)' line is filled but the template's 'List any dependencies' guidance is only partly addressed, the test section only says 'Existing unit tests' with 'N/A', and the checklist items are not all ticked. The reviewer also cannot tell whether any tests were run, because the description verifies only the manifest and lockfile versions. The description is mostly complete, so the check passes.

Full details: Linked Issues check

Explanation

[#4072] Requirement: list google-auth-library in the dependencies of @boxyhq/saml-jackson's package.json. The PR adds google-auth-library 10.6.1 to npm/package.json as a runtime dependency (+1/-0 lines). This meets the declared requirement. The issue has no automated test requirement. The lockfiles (package-lock.json and npm/package-lock.json) are excluded from review by ignored_files, so their sync with the manifest is not verified here. This does not affect the manifest requirement. The version match with the transitive googleapis-common resolution is also not verified, because it depends on the excluded lockfiles. The declared range 10.6.1 satisfies the workaround range shown in the issue (^10.0.0).

Full details: Out of Scope Changes check

Explanation

The reviewed change set is a single added dependency line in npm/package.json. It directly implements the objective of #4072. No unrelated source, test, or configuration changes appear in the summary. The lockfile updates described in the PR body are also dependency-declaration work for the same objective, but they are in ignored_files and were not inspected.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 235f0991-92f9-430d-82f1-5966c1d69ea9
Commits

Reviewing files that changed from the base of the PR and between e13ed65 and 8be1056.

Files ignored due to path filters: 2

  • npm/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1

  • npm/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@boxyhq/saml-jackson 26.2.0 missing google-auth-library dependency

2 participants