manage images: default --cloud to admin

[ideaship]

Problem

A bare osism manage images fails on every standard OSISM deployment with:

ConfigException: Cloud openstack was not found.

The Images command defaulted --cloud to openstack, a profile that cfg-cookiecutter's clouds.yml never ships — it provides admin, admin-system, and octavia. The openstack value was inherited from the standalone openstack-image-manager tool rather than OSISM's own operator-profile convention.

This diverged from the sibling subcommands, all of which already default to admin:

Subcommand	old default	in shipped clouds.yml?
manage images	openstack	no → fails bare
manage flavors	admin	yes → works bare
manage project *	admin	yes → works bare

Change

• Default manage images --cloud to admin, so the documented bare invocation works out of the box.
• Add a regression guard asserting the parsed default.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new test hardcodes knowledge of the cfg-cookiecutter clouds.yml contents; consider centralizing the default cloud name in a shared configuration/constant so future profile changes don’t require hunting down literals in both parser and tests.
• Since other manage subcommands already default to admin, it might be useful to add a small helper or shared base logic for parser construction to ensure all future manage commands use consistent cloud defaults without repeating string literals.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new test hardcodes knowledge of the cfg-cookiecutter `clouds.yml` contents; consider centralizing the default cloud name in a shared configuration/constant so future profile changes don’t require hunting down literals in both parser and tests.
- Since other manage subcommands already default to `admin`, it might be useful to add a small helper or shared base logic for parser construction to ensure all future manage commands use consistent cloud defaults without repeating string literals.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jklare]

LGTM