Repository navigation
Validate migrated scenes against the bone viewer (#468) - #506
Merged
Merged
Conversation
Subomiadekunle
requested review from
UcheWendy,
jacksayshi,
leandrumartin and
mudabs
as code owners
October 11, 2026 15:06
mudabs
approved these changes
Oct 11, 2026
mudabs
left a comment
Collaborator
There was a problem hiding this comment.
Approving. Thanks for the thorough validation work. The D1–D7 write-up and the side-by-side screenshots make the remaining gaps easy to see. I re-ran migration-report.js and got the same numbers (200 items, 179 imported, 334 images, 483 labels, 480 lines, 688 regions). The new tests and lint pass locally.
Since this PR adds no product code, I'm happy to merge it now. A few things should follow up, ideally in one small PR:
- Silent drop-outs. If an item stops importing, every test still passes. I broke
humerus_description.jsonlocally and all 9 tests stayed green. It would help to assert that exactly 179 items import and that the 21 not imported match the ids in D6. - Missing images. An item that loses an image file still imports with fewer images, and the image tests don't catch it. A check that
images.length === totalImagesfor each imported item would fix that. - Label test. The "Only imported together with all of the bone's images" warning counts as one skipped label instead of all of them. A legitimate group skip would fail the test.
- report.md. The committed intro and headings don't match what the script writes, so regenerating it produces a diff.
- D2 numbers. The 176 labels / 152 lines outside the viewer panel aren't calculated anywhere in the PR. It would be good to add that to the script or say how it was measured.
Agree that D1/D2 (label placement) should be a follow-up issue to #467.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468 (part of #463)
This checks that bone content imported into the Scene Editor matches what students see in the bone viewer. I didn't change any import code. #467 was already approved, so this only tests what was merged and writes down the differences.
What's added:
Results:
How to test: