Repository navigation
Keep viewer content usable while scenes are migrated (#469) - #508
Open
Subomiadekunle wants to merge 3 commits into
Open
Subomiadekunle wants to merge 3 commits into
Subomiadekunle wants to merge 3 commits into
Conversation
Subomiadekunle
requested review from
jacksayshi,
leandrumartin and
mudabs
as code owners
October 12, 2026 20:48
Collaborator
|
Thank you. I will hold off on performing a code review. However, I would suggest performing a sync on the branch as I have merged newer changes and this might resolve the 4 conflicts. |
Collaborator
Author
|
@mudabs I updated this branch with the latest main and fixed the merge conflicts by keeping both sets of changes. I also updated one test helper. After #507, importing a bone no longer saves it to the scene right away; the scene only saves when you click Save. The old test assumed importing also saved, so I changed it to import first and then save. All tests pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469 (part of #463)
Keeps the old bone viewer content usable while content is moved into scenes.
What changed:
How to test:
The plan for retiring the old content will be a separate issue, like the notes on #469 say.