Repository navigation
test: round trips of every spec read function over tcp+tls - #5
Merged
Merged
Conversation
TestRoundTrip_everyFunction records every supported read function from a go-modbus tcp+tls server and an mbtest tcp+tls device with client certificates; the capture passes mbcapctl verify and the static and replay servers answer byte for byte. The chaos round trip also runs over tcp+tls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the record → file → replay round-trip tests to
tcp+tls, now that the client takes--tls-cert,--tls-keyand--tls-ca(#3).TestRoundTrip_everyFunctiongains two tcp+tls sources: a go-modbustcp+tlsserver and an mbtest device served over TLS, both with client certificates from a throwaway CA. Every supported read function (FC01–04, 07, 08 data-returning, 11, 12, 17, 20, 24, 43/14) is recorded withclient record. The file passesmbcapctl verify, and the static and replay servers answer byte for byte.TestChaosRoundTrip_everyFunctionalso runs over tcp+tls (busy, dropped, closed, truncated and late answers): only valid answers the device sent are recorded.TestE2ETLS_recordAndReplaycovered FC03, 08, 17, 20 and 24 only.Test-only; no change to RELEASE.md (v3.1.0 is released).
make checkpasses: 0 lint issues,-racetests green, coverage 96.3%.🤖 Generated with Claude Code