Repository navigation
Conversation
On the last day of a budget period the hero tiles compared it with the whole previous period, so on 28 February 28 days met all 31 of January. Only once the period is over does the whole previous one count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
otherworld-dev
added a commit
that referenced
this pull request
Nov 7, 2026
Owner
|
Merged on dev as 9c4758e, with the bundle rebuilt, so I'm closing this here. It'll be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #458.
On the last day of a budget period the dashboard's hero tiles compared the period with the whole previous one, because a period counted as over from its last day on (
today >= current.end). On 28 February that put 28 days of February against all 31 days of January.Now the comparison stays day-for-day through the last day (
today > current.endends it), and the whole previous period is used only once the current one is over.src/utils/formatters.js: one condition plus the docblocktests/js/reportMonthGrouping.test.js: last day of the period, and the day after itjs/budget-app.jsrebuilt🤖 Generated with Claude Code