Repository navigation
fix(signin): say why a sign-in couldn't start in plain words - #25
Merged
Merged
Conversation
When the server didn't answer, Android's sign-in screen showed the raw Go
error ("start login flow: Post …: context deadline exceeded (Client.Timeout
exceeded while awaiting headers)") and the desktop window showed the same
behind "error:". Starting the login flow now returns a short message naming
the server for the common cases: no answer in time, address not found,
connection refused, untrusted certificate, a plain-http server typed without
http://, a 404 (with a hint about Nextcloud in a subfolder), a server error,
and an answer that isn't Nextcloud. The raw error still goes to the log and
stays wrapped for errors.Is. Both apps get it, they show the text as it comes.
d907
# Conflicts: # cmd/nimbo-gui/frontend/dist/assets/index-B4DLXM4K.js # cmd/nimbo-gui/frontend/dist/assets/index-B_IgXu9_.js # cmd/nimbo-gui/frontend/dist/assets/index-DtAKrFT6.js # cmd/nimbo-gui/frontend/dist/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server couldn't be reached, sign-in showed the raw Go error. It now says what went wrong in a short sentence naming the server: no answer, address not found, connection refused, untrusted certificate, a 404, a server error, or an answer that isn't Nextcloud. The raw error still goes to the log.