Repository navigation
feat(gui): show post-processing as a chain of effects - #908
Leonhardmaster2 wants to merge 5 commits into
Conversation
…perties panel Name the undo and recompute handlers in NodeAttributesWidget so another editor in the widget can use them too, and move the reserved scrollbar setup in NodeSettingsWidget into a helper. No behaviour change.
…perties Nodes with the shared post-processing no longer get a Post-Processing section. A row of toggles, one per effect, sits after the node's sections instead. Switching an effect on adds its controls above the row. Switching it off takes them away and puts the value back to neutral. Effects are listed in the order the pass applies them, each with a small icon of what it does. The attributes, their keys and the processing are unchanged, and a project that uses an effect shows it switched on.
…ies panel When the panel shows a single node, its chain moves out of the list and sits at the bottom edge, where it stays while the attributes scroll. With several nodes in the panel each chain stays with its own node.
|
Thanks for the PR! The post-process chain UI is clearly a nice improvement. There are a few structural and UI polish items to address before merging:
|
This replaces the Post-Processing section with a chain of effects, like we discussed on Discord. Right now every node with post-processing gets up to eight rows that mostly sit on values that do nothing, and you can't tell from the collapsed header if any of it is in use. Now the node gets a row of small toggles at the bottom of the properties panel. Switching an effect on adds its controls above the row, switching it off takes them away.
This builds on #907. The first two commits here are that PR, the last three are the GUI.
What changes for users
Saved projects
Saves get the
state.activeflag from the model PR, one boolean on mix, gamma, gain and smoothing. Old projects open the same. Anything set away from neutral shows up as a switched-on effect. For example GradientNorm inCoastalErosionDiffusion.hsdopens with its gain of 2.14 as a stage.Code
The widget is
post_process_dock.cpp. It reuses Meta's slider rows, theRangeBarand the section reveal from the industrial design, and doesn't change Meta.NodeAttributesWidgetkeeps the post-process attributes out of its sections and builds the chain after them.NodeSettingsWidgetmoves it to the bottom edge when only one node is shown.Tested
All on Windows 11 with MSVC 2022 and Qt 6.10.3, one monitor, the default panel design.
devwith its submodules. Each commit builds on its own. No new warnings from these files.CoastalErosionDiffusion.hsd,GammaCorrection.hsdandCellularNoise.hsdload and compute without errors in batch mode.CoastalErosionDiffusion.hsdshows as a stageNot tested