Repository navigation
Declare macOS 14 as the app's minimum, the floor its bundled engine needs - #573
Merged
Merged
Conversation
…eeds The bundled llama-server (b9415) targets macOS 14.0: no upstream prebuilt targets macOS 13 or older, download-runtime.sh gates the binaries at a 14.0 floor, and the QA matrix dropped macOS 13 Ventura for that reason (#469, #472). The app still declared minimumSystemVersion 13.0, which Tauri writes to the bundle's LSMinimumSystemVersion, so on macOS 13 the full and demo apps opened and then failed to start their engine, instead of macOS refusing to open them. tauri.conf.json now declares 14.0; the demo and Steam overlays inherit it. tests/acceptance/test_macos_minimum_version.py reads the floor from download-runtime.sh and fails when the base config, or an overlay release.yml stacks on it, declares less. The artifact inspection suite that gates a Steam upload checks the LSMinimumSystemVersion the build actually wrote, ignoring helper bundles nested inside the app. The QA matrix says the app declares the floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013J2EUgaGKdJEx9AhbrXLmS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found by the pre-release audit of the v0.4.0 pipeline (#495). This is not a regression: v0.2.9 shipped the same way.
The engine's floor is macOS 14. The bundled llama-server (llama.cpp b9415) targets macOS 14.0:
runtimes/llama_cpp/download-runtime.shgates the binaries atMACOS_MINOS_FLOOR14.0;The app still declared 13.0.
apps/desktop/src-tauri/tauri.conf.jsonsetbundle.macOS.minimumSystemVersionto 13.0, which Tauri writes to the bundle'sLSMinimumSystemVersion. On macOS 13, the full and demo apps opened, and the player then watched the engine fail to start; macOS should have refused to open them instead. That is a poor first impression for a demo download.The fix:
tauri.conf.jsonnow declares 14.0. The Steam and demo overlays don't overridebundle.macOS, so both editions inherit it.tests/acceptance/test_macos_minimum_version.py(runs in CI's Acceptance tests job) reads the floor fromdownload-runtime.sh. It fails if the base config, or either overlayrelease.ymlstacks on it, declares less.tests/artifact/test_artifact_inspection.py(the suitesteam-deploy.ymlruns before a Steam upload) checks theLSMinimumSystemVersionthe build actually wrote. It ignores helper bundles nested inside the app.docs/and its docs-site mirror) now says the app declares the floor, and names the test that keeps the two together.Closes #
Checklist
Tests and CI
python -m pytest tests/acceptance/— 138 passed;tests/artifact/skips withoutCONVSIM_ARTIFACT_DIR, as designed)bash scripts/smoke-check.shDocumentation
# SPDX-License-Identifier: Apache-2.0headerTesting notes
.appbundles with a nested helper.appdeclaring 10.13:LSMinimumSystemVersionis missing;.app.Generated by Claude Code