Skip to content

💥 change(kube): rename --allow-from to --admin-whitelist in cluster create - #391

Open
jfbus wants to merge 1 commit into
mainfrom
cluster-allow-from
Open

jfbus wants to merge 1 commit into
mainfrom
cluster-allow-from

Conversation

@jfbus

@jfbus jfbus commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Description

The attribute is named admin_whitelist and cluster update used --admin-whitelist.

This PR fixes the flag in cluster create to be in sync with the attribute and cluster update.

Type of Change

Please check the relevant option(s):

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactor
  • 📝 Documentation update
  • 🔧 Build or CI-related change
  • 🔒 Security fix
  • Other (specify):

How Has This Been Tested?

Please describe the test strategy:

  • Manual testing
  • Unit tests
  • Integration tests
  • Not tested yet

Checklist

  • I have followed the Contributing Guidelines
  • I have added tests or explained why they are not needed
  • I have updated relevant documentation (README, examples, etc.)
  • My changes follow the Conventional Commits specification
  • My commits include appropriate Gitmoji

Additional Context

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

WARNING : Differences in reference doc 🤔

 docs/reference/octl_kube_cluster_create.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Detailed changes

docs/reference/octl_kube_cluster_create.md

-      --allow-from strings                  List of CIDR blocks or IP addresses allowed to access the Kubernetes API
+      --admin-whitelist strings             List of CIDR blocks or IP addresses allowed to access the Kubernetes API

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

DANGER : some flags have been deleted 😱

-octl_kube_cluster_create: --allow-from

Set a "allow-flag-change" label to allow it.

@jfbus jfbus added kind/other Other change breaking-change Backward-incompatible change allow-flag-change ☢️ allow changes in existing flags labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Binary size: 82.3MB => 82.3MB (change +0KB, +0.0%) 😉

@jfbus
jfbus marked this pull request as ready for review November 9, 2026 13:09
@jfbus
jfbus requested a review from a team November 9, 2026 13:09
@jfbus
jfbus requested a review from a team as a code owner November 9, 2026 13:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-flag-change ☢️ allow changes in existing flags breaking-change Backward-incompatible change kind/other Other change

Development

Successfully merging this pull request may close these issues.

1 participant