Repository navigation
Work inside Jupyter's running event loop (#55) - #87
Merged
Merged
Conversation
Jupyter runs an asyncio loop, and asyncio.run() refuses to nest inside it, so every Match and Summary call failed in notebooks. Run the fetch on a worker thread with its own loop when one is already running. Verified by executing a real notebook (both cells failed before, pass after). Refs #55 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Match/Summarycall failed in Jupyter withRuntimeError: asyncio.run() cannot be called from a running event loop. When a loop is already running, the Playwright fetch now runs on a worker thread with its own loop.Verified with an executed notebook (
jupyter nbconvert --execute): before, both cells raised the error; after, they print225 matchesandIND Women won by 17 runs. Unit test covers the running-loop path.Refs #55
🤖 Generated with Claude Code