Repository navigation
Load a match from its match ID alone (#50) - #88
Merged
Merged
Conversation
soodoku
enabled auto-merge (squash)
October 23, 2026 20:33
Match required a series ID that most callers do not have. Without one, load ESPNcricinfo's legacy match URL, which redirects to the full match page for any series, and read series_id from the page. Checked on matches from the 1880s to 2026; #50's match 729303 loads as IPL 2014 (695871). Refs #50 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
soodoku
force-pushed
the
optional-series-id
branch
from
October 23, 2026 20:45
279fe0b to
9623826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match(match_id)now works without a series ID: it loads/matches/engine/match/{id}.html, which ESPNcricinfo redirects to the full match page, and readsseries_idfrom the page. Passing the series ID still uses the direct full-scorecard URL.Checked live on matches from the 1880s to 2026. #50's match:
Match(729303)→ series 695871, 'CSK won by 7 wickets'.Refs #50
🤖 Generated with Claude Code