DUV-4103 Adding custom round with Up and down args - #59
Merged
leocostaba merged 2 commits intoSep 10, 2026
Merged
Conversation
1 task
leocostaba
approved these changes
Sep 10, 2026
leocostaba
pushed a commit
to oxeanbits/parsec
that referenced
this pull request
Sep 10, 2026
# Description ✍️ This PR aims to add new tests for the custom round functionallity available on oxeanbits/equations-parser#59 as well as updating the version of the `equations-parser` folder to it's newer version on the `equations-parser` repository. # Overview 🔍 N/A # Checks ☑️ - [ ] Example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description ✍️
This PR aims to create a custom override of the
roundfunction that allows it to receive an additional parameter, such asround(0.1, "up")andround(0.1, "down"), the first one would return 1, and the second one would return 0, the regularroundwith a single parameter keeps the regular behavior of mathematically correct round (eg.: 0.5~=1, 0.4~=0).Ticket 🎫
https://app.clickup.com/t/9004018935/DUV-4103