standalone: ability to set viona rx/tx queue sizes#1162
Merged
Conversation
FelixMcFelix
left a comment
FelixMcFelix
left a comment
Contributor
There was a problem hiding this comment.
Thanks Ryan, some minor questions around value validity.
| dev.options.get("vnic").unwrap().as_str().unwrap(); | ||
| let rxqsz = match dev.options.get("rx-queue-size") { | ||
| Some(toml::Value::Integer(v)) => { | ||
| hw::virtio::VqSize::new(*v as u16) |
Contributor
There was a problem hiding this comment.
The disposition inside VqSize::new is already to panic if we're not power-of-two aligned. In that light can we have u16::try_from(*v).unwrap() here? That feels better than doing a silent truncation of the most-significant bits.
| }; | ||
| let txqsz = match dev.options.get("tx-queue-size") { | ||
| Some(toml::Value::Integer(v)) => { | ||
| hw::virtio::VqSize::new(*v as u16) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running local network performance benchmarks I find it useful to be able to change queues sizes.