propolis-cli should send boot_order along#1179
Merged
Merged
Conversation
iximeow
added
the
development
iximeow
commented
Jul 20, 2026
| /// `propolis-standalone` | ||
| #[derive(Serialize, Deserialize, Debug, PartialEq, Default)] | ||
| pub struct MachineSettings { | ||
| pub boot_order: Option<Vec<String>>, |
Member
Author
There was a problem hiding this comment.
this gets a whole struct because I've thought for a minute that yoinking the cpus/memory/name fields from a standalone .toml would be really convenient if you're trying to reuse the file in both tools. as it turns out the toml is and has been a valid subset of the settings you'd need for the CLI, so my own /rpool/devel/images/ is full of "*.toml.standalone" which often end up used against propolis-server...
every time I have to open one up to find cpus = and memory = just to pass the CLI flags I think about this (which means about once every four months, to date)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
would you believe that ever since Propolis has been able to set a boot order in fwcfg, we've never tried to use it in
propolis-cli?propolis-standaloneis where I use it often, and of course Nexus just uses the API directly with none of this "CLI program" nonsense.well, @leftwo ran into a case where a VM was busted because the disk's PCI device was changed between where the image was created and the bench cosmo where it was being run, and the solution there is ... set a boot order and boot the thing at least once. we pretty quickly found that propolis-cli wasn't doing the needful, and now it does.