Repository navigation
fix: harden accept gating, unicode handling and installer for OpenCode 2.2.6 - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening pass checked against OpenCode V2 2.2.6 and OpenTUI 0.8.3. The TUI plugin API is unchanged since 2.2.5.
enablednow uses the full eligibility check (visible suggestion, empty idle composer, normal mode, focused), so keys fall through to the host whenever accepting isn't possible./suggeston/off and debug compute the new value inside the store updater, so a quick double press can't write the same value twice.Intl.Segmenter) andmaxCharscounts graphemes. The transcript is sliced by code points, so it can no longer send half of a surrogate pair. Multi-code-point input (IME chunks, combining marks) counts as typing and cancels generation.NONE(e.g.NONE - done,**NONE**) is treated as no suggestion.install.shtoscripts/install.mjs. Every write is planned first, then applied atomically (temp file plus rename), keeping the file mode and following symlink chains.lint:shrunsnode --checkon it.@opentui/*goes to^0.8.1, the floor that the 2.2.6 plugin package declares.@opencode/clientis pinned as a devDependency, since its types were imported without being declared.ghostKeymapLayersandfindComposerEditor, and the unused Promise model path instateless.ts.@opencode/pluginstays at 2.2.5 because 2.2.6 is still inside the 3-dayminimumReleaseAgewindow. Its TUI types are identical to 2.2.5.Type of change
Checklist
bun run testpasses.bun run typecheckpasses.bun run lint:shandbash scripts/changelog.sh checkpass.prompt.footercomposer marker, placeholder ownership or scoped accept-key behaviour.