Repository navigation
Settings lists workflows with the viewer's key when the deployment credential fails - #360
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings lists workflows with the viewer's key when the deployment credential fails (#360)
Settings, Workflows lists the workflows to pick from with the deployment's credential. It fell back to the viewer's own platform key only when the deployment had no credential at all; an expired one is still a non-empty string, so a deployment whose host login had expired showed the expiry error to an administrator whose own key was valid and connected. The catalog now tries the deployment credential and, when it is missing, expired, or rejected, lists the viewer's own account, and says so on the page: until the deployment credential is renewed, other viewers can run a picked workflow only if it is already in their own account, since adding a copy reads the deployment's version. The response carries
source(deploymentorviewer). One new test; all server and web tests pass.