Brand images carry a version in their address - #361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brand images carry a version in their address (#361)
The brand icon and favicon were always served at the same address (
/api/brand-icon,/api/favicon) with an hour of browser caching, so changing the icon in Settings left browsers showing the old one for up to an hour. Each address now carriesv=, a short hash of the configured path or URL plus the file's modification time, so a different image, or the same file replaced, is a new address that browsers fetch at once. The installable-app manifest uses the same versioned address. A new test checks that replacing the file changes the address; all tests pass.