Repository navigation
Workflow form fields look like inputs again - #365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow form fields look like inputs again (#365)
In a workflow's form, text and number fields rendered as bare text: no border, no background, no padding. The form library draws them with a global
input, textarearule in abasecascade layer. Since v1.65's layer ordering (web/src/layers.css), the Studio ranks that layer below the shared packages' Tailwind resets on purpose, so it cannot restyle inputs elsewhere in the Studio; inside the workflow form the resets therefore won and stripped the fields. Selects and text areas were unaffected because the Studio draws those itself.The workflow form now gets the Studio's own field look, scoped to
.wf-form: border, input background, 6px radius, padding, a focus ring, a muted placeholder, and a 32px height shared with the Studio's selects. A combobox input keeps room on the right for its arrow button.The library's Yes/No switch paints its handle and its unselected half with a fixed white-to-gray gradient and has no dark variant, so in dark mode it showed as a bright white bar; in dark mode those parts now take shades of the panel color, with the handle a step lighter than the label. This also applies to the switches in Settings.
Checked in headless Chrome on a marketplace workflow's form (cluster picker, switches, text fields, a single-select dropdown, a multi-select) in light and dark: every field has a 1px border, the input background, and 8px padding. All tests pass.