Skip to content

test: the dedup test holds the first delivery until the repeated publish #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giraffesyo merged 1 commit into from
Oct 2, 2026
Merged

test: the dedup test holds the first delivery until the repeated publish #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions messaging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,14 @@ func TestPublishDedupAndReplay(t *testing.T) {
h := newHarness(t)
ctx := context.Background()
var calls sync.Map
// The first delivery is held until the repeated publish has been made:
// its dedup key is free again as soon as it is finalized.
release := make(chan struct{})
unblock := sync.OnceFunc(func() { close(release) })
defer unblock()
workers := hopper.NewWorkers()
hopper.Subscribe(workers, hopper.Subscription{Name: "flaky", Pattern: "allocation.created", MaxAttempts: 1}, func(_ context.Context, msg *hopper.Message[allocationCreated]) error {
<-release
n, _ := calls.LoadOrStore(msg.ID, new(int))
*n.(*int)++
if *n.(*int) == 1 {
Expand All @@ -155,6 +161,7 @@ func TestPublishDedupAndReplay(t *testing.T) {
if len(again.Deliveries) != 1 || !again.Deliveries[0].Duplicate || again.Deliveries[0].Job.ID != first.Deliveries[0].Job.ID {
t.Errorf("repeated publish = %+v", again.Deliveries[0])
}
unblock()

// The single attempt fails and the delivery is dead-lettered; replay
// re-drives it and it succeeds.
Expand Down
Loading