Repository navigation
Conversation
, GHSA-cf8x-9m69-3gg3) Co-authored-by: Aymeric Rabot <Aymericr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Aymeric Rabot <Aymericr@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Security bump of the Bun toolchain from 1.3.14 to 1.4.4. 1.4.4 is the first patched version for three High advisories in
oven-sh/bun:bun install. Affects versions < 1.4.4.This matters most for
release.yml, which runsbun installbefore publishing@pascal-app/lingoto npm.Changes (toolchain pins and docs only, no library or app code):
package.json:packageManageris nowbun@1.4.4. This is the onlypackage.jsonthat pins Bun..github/workflows/ci.yml:bun-version: 1.4.4in all 3setup-bunsteps (check, node-support, site)..github/workflows/release.yml:bun-version: 1.4.4.apps/site/vercel.json(new): Vercel picks Bun based on the lockfile format and ignorespackageManager, so the dc07bbf preview still installed with Bun 1.3.14. The Vercel project's root directory isapps/site, and the file followspascalorg/private-editor's pattern:installCommand:cd ../.. && npx -y bun@1.4.4 install --frozen-lockfilebuildCommand:cd ../.. && npx -y bun@1.4.4 run build --filter=lingo-site. This replaces the previousbunx turbo run build --filter=lingo-site. The site build callsbun run typecheck, and nestedbuncalls inherit 1.4.4 from the outerbun run.AGENTS.mdandCONTRIBUTING.md: the stated Bun version is now 1.4.4.The repo has no Dockerfile,
.bun-version, or.tool-versions.react-doctor.ymldoesn't install Bun.bun.lockis unchanged. Bun 1.4.4 accepts the existing lockfile (lockfileVersion: 1) withbun install --frozen-lockfileand doesn't rewrite it, so no other dependencies change.The Vercel preview at a18f290 logs
bun install v1.4.4 (38afee6c8).This doesn't trigger a release:
release.ymlruns only onworkflow_dispatch.Checklist
Gates (run locally with Bun 1.4.4 and Node 22)
bun run checkgreen (typecheck, tests, build, size budgets, corpus gate, zero-deps gate)bun run lintgreensitejob and Vercel preview)Knowledge layer