Dynamically require combustion/application only in #initialize! - #145
Open
jrochkind wants to merge 1 commit into
Open
Dynamically require combustion/application only in #initialize!#145jrochkind wants to merge 1 commit into
jrochkind wants to merge 1 commit into
Conversation
To avoid Rails 8.2 alpha load-order warnings when config/application is loaded earlier and registers initializers before Rails framework has been loaded properly.
Contributor
Author
|
I'm not sure if the build errors are related to my change or not; perhaps I have indeed messed up the setup for test? To the extent I can get tests to run locally -- it was a bit tricky to figure out how -- I don't seem to be able to reproduce the failure. I have run local tests with sqlite3 and had them pass. Advice welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid Rails 8.2 alpha load-order warnings when config/application is loaded earlier and registers initializers before Rails framework has been loaded properly.
Closes #144