Skip to content

Dynamically require combustion/application only in #initialize! - #145

Open
jrochkind wants to merge 1 commit into
pat:mainfrom
jrochkind:avoid_rails_load_order
Open

Dynamically require combustion/application only in #initialize!#145
jrochkind wants to merge 1 commit into
pat:mainfrom
jrochkind:avoid_rails_load_order

Conversation

@jrochkind

Copy link
Copy Markdown
Contributor

To avoid Rails 8.2 alpha load-order warnings when config/application is loaded earlier and registers initializers before Rails framework has been loaded properly.

Closes #144

To avoid Rails 8.2 alpha load-order warnings when config/application is loaded earlier and registers initializers before Rails framework has been loaded properly.
@jrochkind jrochkind changed the title Dynamically require combustion/application only in #initialize\! Dynamically require combustion/application only in #initialize! Aug 26, 2026
@jrochkind

jrochkind commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure if the build errors are related to my change or not; perhaps I have indeed messed up the setup for test?

An error occurred while loading spec_helper.rb.
Failure/Error:
  ActiveRecord::Base.configurations = YAML.safe_load(
    ERB.new(database_yaml).result, :aliases => true
  )

ActiveRecord::AdapterNotSpecified:
  'development' database is not configured. Available: ["test", "test_another"]

To the extent I can get tests to run locally -- it was a bit tricky to figure out how -- I don't seem to be able to reproduce the failure. I have run local tests with sqlite3 and had them pass.

Advice welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.2.0.alpha on main at 27fb2a9192b2 triggers Rails load order warning

1 participant