Skip to content

Handle string keyed arguments in remove() - #34

Open
DavidBadura wants to merge 1 commit into
2.0.xfrom
string-keyed-arguments
Open

DavidBadura wants to merge 1 commit into
2.0.xfrom
string-keyed-arguments

Conversation

@DavidBadura

Copy link
Copy Markdown
Member

Called with named arguments, remove() gets a string keyed array, so $id[0] does not exist and nothing is deleted. insert() and update() already normalize their arguments since #31; remove() now does the same, and an integration test covers all three with string keyed arguments.

remove() had the same problem as insert() and update(): called with named
arguments, $id[0] does not exist and nothing gets deleted. The new test
covers all three methods with string keyed arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant