Promote macOS in-app updates to main - #40
Merged
Merged
Conversation
feat(macos): install updates while preserving proxy state
test(macos): keep POSIX updater fixtures off Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote the reviewed macOS updater from
developmenttomain. Source PR: #39; promotion head:0e9a408ceaf243db8cab044b23e2eda4eb910fec.CodexCommander can check for stable updates and install them from the menu app while preserving the user’s proxy, routing, and service choices. Installation pauses the bundled proxy before download and restores the appropriate state after relaunch.
This implements U1–U6 of the updater plan. Existing v0.1.6 installations need one manual bootstrap to the first updater-enabled release; release publication is handled separately from this promotion.
Behavior and recovery
Security and distribution
Security review covers the pinned Sparkle dependency, helper/admission boundaries, signing-key custody, and release artifacts. Sparkle 2.9.6 is pinned with artifact/tool checksums; both feed and archive signatures are required, with strict feed verification and verification before extraction. Private signing keys remain outside release asset directories. Bundle components are signed inside-out and the universal archive is checked again after extraction.
Apple Developer ID signing and notarization remain deferred. Qualification uses disposable update-signing keys and ad-hoc app signatures; it does not establish notarized distribution readiness. Publishing must assemble and verify a complete draft release before advertising it as latest.
Validation
Windows qualification identified macOS-only fixtures using POSIX directory fsync and bundle path syntax. PR #42 scopes those fixtures to Linux/macOS while preserving platform-independent service-command tests on Windows; production durability and recovery guards are unchanged. The corrected tree passed the full 623-file local suite and PR CI. macOS and Windows cross-platform requalification passed on identical tree
858219b4765267157e23f658208958bf48c0f59f.bun run typecheck,bun run test:parallel(623 files),bun run prepush(623 shards and privacy scan), andbun run lint:guipassed; lint retains one existing warning.bun run test:macos: 156 core and 79 UI tests passed. The final intent-preservation fixes passed 30 focused Bun tests and independent review.Installed qualification used source revision
4d23fac1d; subsequent intent-preservation and discovery-UI changes were verified with focused regressions, independent review, and the full suite. The full state/fault/CPU cross-product was not run. Both validated review findings are fixed; none remain unapplied.Session-settled decisions carried from planning: early pause before download (user-approved), Update Anyway/Later interruption consent (user-directed), quiet automatic discovery with on-demand disclosure (user-directed revision after the menu screenshot), and Apple signing later (user-directed).
Demo
Actual AppKit menu and installation confirmation captured in an isolated UI fixture. The menu states are supplied by the fixture; native tests separately verify real Sparkle background discovery and focus behavior.