Conversation
Collaborator
Coverage Report for CI Build 36194121045Coverage remained the same at 86.869%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
ffi-url-drop
branch
from
September 25, 2026 21:55
581eef9 to
ee62798
Compare
Member
|
seems like a simple oversight that got forgotten to be removed to me |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1905
This removes the url dep in payjoin-ffi in favor of using the native payjoin url. I feel like there was a reason we told ourselves why we didn't want this at first but I can't find it for the life of me so I thought I should just put it out into the wild to see what we think.
I also notices there were some pretty egregious test errors where we were using url parsing instead of uri parsing.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.