Skip to content

Remove url from payjoin-ffi in favor of native payjoin::url - #1907

Draft
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:ffi-url-drop
Draft

benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:ffi-url-drop

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

Closes #1905

This removes the url dep in payjoin-ffi in favor of using the native payjoin url. I feel like there was a reason we told ourselves why we didn't want this at first but I can't find it for the life of me so I thought I should just put it out into the wild to see what we think.

I also notices there were some pretty egregious test errors where we were using url parsing instead of uri parsing.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

coveralls commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 36194121045

Coverage remained the same at 86.869%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17013
Covered Lines: 14779
Line Coverage: 86.87%
Coverage Strength: 333.85 hits per line

💛 - Coveralls

@DanGould

Copy link
Copy Markdown
Member

seems like a simple oversight that got forgotten to be removed to me

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should our Url implementation replace url as a dep in payjoin-ffi?

3 participants