Repository navigation
feat(csharp-ci): upload the merged cobertura report as <prefix>-coverage-report - #43
Merged
Merged
Conversation
monsieurleberre
marked this pull request as ready for review
September 29, 2026 11:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd97043783
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
csharp-ci.yaml: right afterMerge per-project cobertura reports, the coverage shard (if: matrix.coverage) uploadscoverage/merged.cobertura.xmlas artifact${{ inputs.artifact-prefix }}-coverage-report(defaultcsharp-coverage-report),retention-days: 1,if-no-files-found: error. Sameactions/upload-artifactSHA pin (v7.0.1) as the file's other uses. README and CHANGELOG[Unreleased]/ Added updated (additive, next release 2.6.0).Why
canton-dotnet-sdk-internal is removing its separate coverage re-run. It needs the merged report to keep an "every src module appears in coverage" guard without running the tests twice.
Collisions
Name is distinct from
<prefix>-coverage-percentand<prefix>-ci-result-*.scala-ci.yamlalready uploads its Cobertura file (coverage-artifact-name, defaultscala-coverage), so no change there and no clash with csharp in the same caller run.Checks
test/*.py,test/*_test.sh) all pass.job.workflow_shacomplaints (3 lines) from the local actionlint version; none from the new step.